Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove sandbox base image and force_deploy_build. Generalise in check_rebuild. #2645

Merged
merged 5 commits into from
Oct 4, 2023
Merged

chore: Remove sandbox base image and force_deploy_build. Generalise in check_rebuild. #2645

merged 5 commits into from
Oct 4, 2023

Conversation

charlielye
Copy link
Contributor

Base image not really needed as build happens in yarn-project and we're just stripping dev deps.
force_deploy_build was workaround for ensuring version number is baked into image. We should probably just find a way to correctly invalidate the content hash, but in meantime i've generalised in check_rebuild by checking if the commit tag is set (i.e. deploying) and the dockerfile has an ARG COMMIT_TAG= in it, which we know will carry this new version number.

@charlielye charlielye requested a review from PhilWindle October 3, 2023 15:27
@charlielye charlielye changed the title Remove sandbox base image and force_deploy_build. Generalise in check_rebuild. chore: Remove sandbox base image and force_deploy_build. Generalise in check_rebuild. Oct 3, 2023
@spypsy spypsy mentioned this pull request Oct 3, 2023
Merged
4 tasks
@benesjan
Copy link
Contributor

benesjan commented Oct 4, 2023

@charlielye I just used the old approach for deploying pxe docker image in this PR. Lmk if you would like me to update that and fix the conflicts here.

@charlielye charlielye merged commit 805fe18 into master Oct 4, 2023
@charlielye charlielye deleted the cl/no_base_sandbox branch October 4, 2023 11:16
@AztecBot AztecBot mentioned this pull request Oct 4, 2023
Merged
spalladino pushed a commit that referenced this pull request Oct 4, 2023
@AztecBot
chore(master): Release 0.8.2 (#2669)
e262793 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.8.2</summary>

##
[0.8.2](aztec-packages-v0.8.1...aztec-packages-v0.8.2)
(2023-10-04)


### Features

* Constrain return notes from oracle call.
([#2639](#2639))
([248be1b](248be1b))
* Multiple pixies 1 Sandbox
([#2492](#2492))
([572d572](572d572))
* Take an optional owner to create the initialization nullifier
([#2647](#2647))
([fefc443](fefc443))


### Bug Fixes

* Add missing properties to deployed packages
([#2678](#2678))
([343df30](343df30))
* Include ignition data in package or save after 1st download
([#2591](#2591))
([d5e9f8b](d5e9f8b)),
closes
[#2445](#2445)
* Make target architecture configurable, target westmere in GA.
([#2660](#2660))
([3cb9639](3cb9639))
* Removal of setting private data root in kernel prover
([#2671](#2671))
([6a2cc28](6a2cc28)),
closes
[#778](#778)


### Miscellaneous

* 1 deploy_dockerhub CI task
([#2670](#2670))
([dff396c](dff396c))
* Check that portal address is saved
([#2641](#2641))
([9ebef6e](9ebef6e))
* Fixes in deploy scripts
([#2659](#2659))
([f44568b](f44568b))
* Measure circuit simulation times and input/output sizes
([#2663](#2663))
([027f7ec](027f7ec))
* Remove sandbox base image and force_deploy_build. Generalise in
check_rebuild.
([#2645](#2645))
([805fe18](805fe18))
</details>

<details><summary>barretenberg.js: 0.8.2</summary>

##
[0.8.2](barretenberg.js-v0.8.1...barretenberg.js-v0.8.2)
(2023-10-04)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg: 0.8.2</summary>

##
[0.8.2](barretenberg-v0.8.1...barretenberg-v0.8.2)
(2023-10-04)


### Bug Fixes

* Include ignition data in package or save after 1st download
([#2591](#2591))
([d5e9f8b](d5e9f8b)),
closes
[#2445](#2445)
* Make target architecture configurable, target westmere in GA.
([#2660](#2660))
([3cb9639](3cb9639))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request Oct 5, 2023
@AztecBot
chore(master): Release 0.8.2 (#2669)
3bf55ed 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.8.2</summary>

##
[0.8.2](AztecProtocol/aztec-packages@aztec-packages-v0.8.1...aztec-packages-v0.8.2)
(2023-10-04)


### Features

* Constrain return notes from oracle call.
([#2639](AztecProtocol/aztec-packages#2639))
([248be1b](AztecProtocol/aztec-packages@248be1b))
* Multiple pixies 1 Sandbox
([#2492](AztecProtocol/aztec-packages#2492))
([572d572](AztecProtocol/aztec-packages@572d572))
* Take an optional owner to create the initialization nullifier
([#2647](AztecProtocol/aztec-packages#2647))
([fefc443](AztecProtocol/aztec-packages@fefc443))


### Bug Fixes

* Add missing properties to deployed packages
([#2678](AztecProtocol/aztec-packages#2678))
([343df30](AztecProtocol/aztec-packages@343df30))
* Include ignition data in package or save after 1st download
([#2591](AztecProtocol/aztec-packages#2591))
([d5e9f8b](AztecProtocol/aztec-packages@d5e9f8b)),
closes
[#2445](AztecProtocol/aztec-packages#2445)
* Make target architecture configurable, target westmere in GA.
([#2660](AztecProtocol/aztec-packages#2660))
([3cb9639](AztecProtocol/aztec-packages@3cb9639))
* Removal of setting private data root in kernel prover
([#2671](AztecProtocol/aztec-packages#2671))
([6a2cc28](AztecProtocol/aztec-packages@6a2cc28)),
closes
[#778](AztecProtocol/aztec-packages#778)


### Miscellaneous

* 1 deploy_dockerhub CI task
([#2670](AztecProtocol/aztec-packages#2670))
([dff396c](AztecProtocol/aztec-packages@dff396c))
* Check that portal address is saved
([#2641](AztecProtocol/aztec-packages#2641))
([9ebef6e](AztecProtocol/aztec-packages@9ebef6e))
* Fixes in deploy scripts
([#2659](AztecProtocol/aztec-packages#2659))
([f44568b](AztecProtocol/aztec-packages@f44568b))
* Measure circuit simulation times and input/output sizes
([#2663](AztecProtocol/aztec-packages#2663))
([027f7ec](AztecProtocol/aztec-packages@027f7ec))
* Remove sandbox base image and force_deploy_build. Generalise in
check_rebuild.
([#2645](AztecProtocol/aztec-packages#2645))
([805fe18](AztecProtocol/aztec-packages@805fe18))
</details>

<details><summary>barretenberg.js: 0.8.2</summary>

##
[0.8.2](AztecProtocol/aztec-packages@barretenberg.js-v0.8.1...barretenberg.js-v0.8.2)
(2023-10-04)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg: 0.8.2</summary>

##
[0.8.2](AztecProtocol/aztec-packages@barretenberg-v0.8.1...barretenberg-v0.8.2)
(2023-10-04)


### Bug Fixes

* Include ignition data in package or save after 1st download
([#2591](AztecProtocol/aztec-packages#2591))
([d5e9f8b](AztecProtocol/aztec-packages@d5e9f8b)),
closes
[#2445](AztecProtocol/aztec-packages#2445)
* Make target architecture configurable, target westmere in GA.
([#2660](AztecProtocol/aztec-packages#2660))
([3cb9639](AztecProtocol/aztec-packages@3cb9639))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Maddiaa0 pushed a commit that referenced this pull request Oct 6, 2023
@charlielye @Maddiaa0
chore: Remove sandbox base image and force_deploy_build. Generalise i…
3b7b36c 
…n check_rebuild. (#2645)

Base image not really needed as build happens in yarn-project and we're
just stripping dev deps.
force_deploy_build was workaround for ensuring version number is baked
into image. We should probably just find a way to correctly invalidate
the content hash, but in meantime i've generalised in check_rebuild by
checking if the commit tag is set (i.e. deploying) and the dockerfile
has an `ARG COMMIT_TAG=` in it, which we know will carry this new
version number.
Maddiaa0 pushed a commit that referenced this pull request Oct 6, 2023
@AztecBot @Maddiaa0
chore(master): Release 0.8.2 (#2669)
1f7a0f4 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.8.2</summary>

##
[0.8.2](aztec-packages-v0.8.1...aztec-packages-v0.8.2)
(2023-10-04)


### Features

* Constrain return notes from oracle call.
([#2639](#2639))
([248be1b](248be1b))
* Multiple pixies 1 Sandbox
([#2492](#2492))
([572d572](572d572))
* Take an optional owner to create the initialization nullifier
([#2647](#2647))
([fefc443](fefc443))


### Bug Fixes

* Add missing properties to deployed packages
([#2678](#2678))
([343df30](343df30))
* Include ignition data in package or save after 1st download
([#2591](#2591))
([d5e9f8b](d5e9f8b)),
closes
[#2445](#2445)
* Make target architecture configurable, target westmere in GA.
([#2660](#2660))
([3cb9639](3cb9639))
* Removal of setting private data root in kernel prover
([#2671](#2671))
([6a2cc28](6a2cc28)),
closes
[#778](#778)


### Miscellaneous

* 1 deploy_dockerhub CI task
([#2670](#2670))
([dff396c](dff396c))
* Check that portal address is saved
([#2641](#2641))
([9ebef6e](9ebef6e))
* Fixes in deploy scripts
([#2659](#2659))
([f44568b](f44568b))
* Measure circuit simulation times and input/output sizes
([#2663](#2663))
([027f7ec](027f7ec))
* Remove sandbox base image and force_deploy_build. Generalise in
check_rebuild.
([#2645](#2645))
([805fe18](805fe18))
</details>

<details><summary>barretenberg.js: 0.8.2</summary>

##
[0.8.2](barretenberg.js-v0.8.1...barretenberg.js-v0.8.2)
(2023-10-04)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg: 0.8.2</summary>

##
[0.8.2](barretenberg-v0.8.1...barretenberg-v0.8.2)
(2023-10-04)


### Bug Fixes

* Include ignition data in package or save after 1st download
([#2591](#2591))
([d5e9f8b](d5e9f8b)),
closes
[#2445](#2445)
* Make target architecture configurable, target westmere in GA.
([#2660](#2660))
([3cb9639](3cb9639))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilWindle PhilWindle PhilWindle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charlielye @benesjan @PhilWindle