Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not log failing fetch retry attempts #2008

Closed
spalladino opened this issue Sep 5, 2023 · 1 comment
Closed

Do not log failing fetch retry attempts #2008

spalladino opened this issue Sep 5, 2023 · 1 comment
Labels
T-bug Type: Bug. Something is broken.

Comments

@spalladino
Copy link
Collaborator

spalladino commented Sep 5, 2023

It's annoying for the user to see all the retries done by our retrying-fetch under the hood, especially with the so frequent SocketError we still have. We should only show an error if all retries have been consumed.

Requested on Discord along with #2007

QoL request re: makeFetch errors
when testing, I send a tx that I know will fail. it will print the error foundation:retry ERROR Error: Assertion failed: '...' three times via the makeFetch retry. This doesn't have any positive purpose IMO since the ts interface will throw an error for the dev to handle. It should probably also short-circuit the retry loop if the error is Assertion failed:
the fetch failed error SocketError: other side closed is common and clutters the cli too. Instead of logging this error, it should just throw if all retries fail and let the dev handle it
I know the api optionally takes DebugLogger but I am not providing it. I think the ideal situation would be to log retry errors only if the debug logger is provided.

@spalladino spalladino added the T-bug Type: Bug. Something is broken. label Sep 5, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Sep 5, 2023
@spalladino spalladino added this to the 📢 Initial Public Sandbox Release milestone Sep 5, 2023
@spypsy
Copy link
Member

spypsy commented Sep 7, 2023

Fixed in #2015

@spypsy spypsy closed this as completed Sep 7, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bug Type: Bug. Something is broken.
Projects
Archived in project
Development

No branches or pull requests

2 participants