You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's annoying for the user to see all the retries done by our retrying-fetch under the hood, especially with the so frequent SocketError we still have. We should only show an error if all retries have been consumed.
QoL request re: makeFetch errors
when testing, I send a tx that I know will fail. it will print the error foundation:retry ERROR Error: Assertion failed: '...' three times via the makeFetch retry. This doesn't have any positive purpose IMO since the ts interface will throw an error for the dev to handle. It should probably also short-circuit the retry loop if the error is Assertion failed:
the fetch failed error SocketError: other side closed is common and clutters the cli too. Instead of logging this error, it should just throw if all retries fail and let the dev handle it
I know the api optionally takes DebugLogger but I am not providing it. I think the ideal situation would be to log retry errors only if the debug logger is provided.
The text was updated successfully, but these errors were encountered:
It's annoying for the user to see all the retries done by our retrying-fetch under the hood, especially with the so frequent
SocketError
we still have. We should only show an error if all retries have been consumed.Requested on Discord along with #2007
The text was updated successfully, but these errors were encountered: