Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unencrypted Logs from Private Token Contract #1757

Closed
suyash67 opened this issue Aug 23, 2023 · 1 comment
Closed

Remove Unencrypted Logs from Private Token Contract #1757

suyash67 opened this issue Aug 23, 2023 · 1 comment
Assignees

Comments

@suyash67
Copy link
Contributor

suyash67 commented Aug 23, 2023

We emit unencrypted logs from the private functions in the private token contract. This leaks privacy (spotted original by Mike in #1689). But for the sandbox release, we still kept these unencrypted logs for the private token contract because it was being used in the docs to demonstrate retrieval of logs. Longer term, we should remove these unencrypted logs from this contract and update the docs to use a different example for retrieval of unencrypted logs.

emit_unencrypted_log(&mut context, "Balance set in constructor");

emit_unencrypted_log(&mut context, "Coins minted");

emit_unencrypted_log(&mut context, "Coins transferred");

Most (if not all) of such logs can be found by grepping 'TODO(1757)'

@github-project-automation github-project-automation bot moved this to Todo in A3 Aug 23, 2023
@benesjan benesjan self-assigned this Aug 23, 2023
@iAmMichaelConnor iAmMichaelConnor added this to the 📢 Initial Public Sandbox Release milestone Aug 25, 2023
@benesjan
Copy link
Contributor

Addressed by #1780

@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants