Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(simulator): initialize ACVM's SimulatedBackend separately (setup pedersen init only happens once) #1596

Merged
merged 14 commits into from
Aug 17, 2023
Merged

chore(simulator): initialize ACVM's SimulatedBackend separately (setup pedersen init only happens once) #1596

merged 14 commits into from
Aug 17, 2023

Conversation

dbanks12
Copy link
Collaborator

@dbanks12 dbanks12 commented Aug 16, 2023 •
edited
Loading

Resolves #1553

Blocked by noir-lang/acvm#495

@dbanks12 dbanks12 marked this pull request as draft August 17, 2023 12:49
@dbanks12
Copy link
Collaborator Author

Converted to draft until I resolve ACVM PR feedback.

@dbanks12 dbanks12 marked this pull request as ready for review August 17, 2023 17:09
@dbanks12
Copy link
Collaborator Author

@TomAFrench agrees that it is probably fine to point Aztec to my acvm branch for now while review of that is ongoing. Speed improvements in Aztec are worth getting asap.

ludamad
ludamad approved these changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@ludamad ludamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this is ready LGTM, having an unstable branch is probably fine as we don't get a ton of updates to this component I think

@dbanks12 dbanks12 enabled auto-merge (squash) August 17, 2023 18:07
@dbanks12 dbanks12 merged commit 1a260ed into master Aug 17, 2023
@dbanks12 dbanks12 deleted the db/acvm-init-pedersen-once branch August 17, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludamad ludamad ludamad approved these changes

@sirasistant sirasistant Awaiting requested review from sirasistant

@iAmMichaelConnor iAmMichaelConnor Awaiting requested review from iAmMichaelConnor

Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Figure out why the Note Processor is so slow (multi-transfer example)
2 participants
@dbanks12 @ludamad