chore: Split SumcheckRound into Prover/Verifier classes #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ledwards2225
changed the title
ludamad
reviewed
Aug 2, 2023
| template <typename... T> | ||
| static constexpr void add_tuples(std::tuple<T...>& tuple_1, const std::tuple<T...>& tuple_2) | ||
| { | ||
| [&]<std::size_t... I>(std::index_sequence<I...>) { ((std::get<I>(tuple_1) += std::get<I>(tuple_2)), ...); } |
There was a problem hiding this comment.
Nitpick: This took me a bit to realize this is a lambda being called - maybe we could assign the lambda?
auto add_tuples_helper = ....
add_tuples_helper(std::make_index_sequence<sizeof...(T)>{})
There was a problem hiding this comment.
That was indeed gross and I've removed the lambda altogether and simplified it to a single fold expression
There was a problem hiding this comment.
Scratch that. Thought I was clever but most of the compilers didn't like it. Went with your original suggestion
ludamad
approved these changes
Aug 2, 2023
ledwards2225
force-pushed
the
lde/split_sumcheck_round
branch
2 times, most recently
from
e318a42 to
5a0d94a
Compare
ludamad
approved these changes
Aug 2, 2023
ledwards2225
force-pushed
the
lde/split_sumcheck_round
branch
4 times, most recently
from
fbcec75 to
da5027c
Compare
ledwards2225
force-pushed
the
lde/split_sumcheck_round
branch
from
da5027c to
a742f9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split
SumcheckRoundintoSumcheckRoundProverandSumcheckRoundVerifierin support of the recursive verifier work. We do not want to inadvertently instantiate "prover functionality" with stdlib types when instantiatingUltraVerifier_<flavor::UltraRecursive>. Sumcheck itself was split in a previous PR but SumcheckRound was overlooked.Checklist: