Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: simulator split #11144

Merged
merged 38 commits into from
Jan 11, 2025
Merged

feat: simulator split #11144

merged 38 commits into from
Jan 11, 2025

Conversation

Thunkar
Copy link
Contributor

@Thunkar Thunkar commented Jan 10, 2025

  • Modularises @aztec/simulator to provide /client and /serverbundles.
  • Makes both bb-prover and pxe take a SimulatorProvider as an argument, so web bundles can initialise a single wasm version on a common entrypoint.
  • Uses said simulator provider for everything!
  • Unifies aztec-packages to always use acvm_js to execute circuits, instead of sometimes noir_js(for protocol circuits). This forces some code repetiton ATM, but again, unifies codepaths and used dependencies.

All of this allows us to again simplify the the web bundles and avoid the need for weird wasm initialization hacks. Async loading is also now properly supported, which allows us to display meaningful content on a webapp near instantly.

@Thunkar Thunkar self-assigned this Jan 10, 2025
@Thunkar Thunkar requested a review from sirasistant January 10, 2025 06:38
@AztecBot
Copy link
Collaborator

AztecBot commented Jan 10, 2025

Docs Preview

Hey there! 👋 You can check your preview at https://6782307a6b77a02572934c62--aztec-docs-dev.netlify.app

Copy link
Collaborator

@sirasistant sirasistant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@fcarreiro fcarreiro removed their request for review January 10, 2025 10:37
@Thunkar Thunkar added e2e-all CI: Enables this CI job. network-all Run this CI job. labels Jan 10, 2025
@Thunkar Thunkar merged commit 9b99126 into master Jan 11, 2025
77 checks passed
@Thunkar Thunkar deleted the gj/simulator_split branch January 11, 2025 10:55
TomAFrench added a commit that referenced this pull request Jan 13, 2025
* master: (329 commits)
  fix(avm): mac build (#11195)
  fix: docs rebuild patterns (#11191)
  chore: refactor Solidity Transcript and improve error handling in  sol_honk flow (#11158)
  chore: move witness computation into class plus some other cleanup (#11140)
  fix: get_next_power_exponent off by 1 (#11169)
  chore(avm): vm2 followup cleanup (#11186)
  fix: underconstrained bug (#11174)
  refactor: VariableMerkleTree readability improvements (#11165)
  chore: removing noir bug workaround (#10535)
  chore(docs): Remove node pages  (#11161)
  git subrepo push --branch=master noir-projects/aztec-nr
  git_subrepo.sh: Fix parent in .gitrepo file. [skip ci]
  chore: replace relative paths to noir-protocol-circuits
  git subrepo push --branch=master barretenberg
  feat(avm2): avm redesign init (#10906)
  feat: Sync from noir (#11138)
  feat: simulator split (#11144)
  chore: rpc server cleanup & misc fixes (#11145)
  git subrepo push --branch=master noir-projects/aztec-nr
  git_subrepo.sh: Fix parent in .gitrepo file. [skip ci]
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e-all CI: Enables this CI job. network-all Run this CI job.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants