Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): ensure that prover.toml files in protocol circuits are in sync #11141

Merged
merged 8 commits into from
Jan 10, 2025

Conversation

TomAFrench
Copy link
Member

@TomAFrench TomAFrench commented Jan 10, 2025

#11096 broke Noir CI as the Prover.toml files weren't updated to take into account the new circuits. This PR executes the protocol circuits with these inputs to check they're valid.

noir-projects/Earthfile Outdated Show resolved Hide resolved
noir-projects/Earthfile Outdated Show resolved Hide resolved
@TomAFrench
Copy link
Member Author

TomAFrench commented Jan 10, 2025

@LeilaWang I've used the method specified in #11011 to regenerate these inputs but it's still not liking it. Can someone on protocol circuits team help take a look at this please?

@MirandaWood
Copy link
Contributor

@LeilaWang I've used the method specified in #11011 to regenerate these inputs but it's still not liking it. Can someone on protocol circuits team help take a look at this please?

Hey, looks like the removal of test_circuit_prover.ts in #11102 removed the code to pad reset inputs to the largest variant for the Prover.toml file, so reset will fail. Looking into it now, hopefully not too hard a fix!

@TomAFrench
Copy link
Member Author

Thank you!

@TomAFrench TomAFrench enabled auto-merge (squash) January 10, 2025 13:24
@TomAFrench TomAFrench merged commit db769bd into master Jan 10, 2025
48 checks passed
@TomAFrench TomAFrench deleted the tf/add-ci-to-check-prover-toml-consistency branch January 10, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants