chore: move witness computation into class plus some other cleanup #11140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iakovenkos
reviewed
Jan 13, 2025
Comment on lines
9
to
12
| * @brief Class for all the oink rounds, which are shared between the folding prover and ultra prover. | ||
| * @details This class contains execute_preamble_round(), execute_wire_commitments_round(), | ||
| * execute_sorted_list_accumulator_round(), execute_log_derivative_inverse_round(), and | ||
| * execute_grand_product_computation_round(). |
There was a problem hiding this comment.
the docs are stale, I would suggest something along the lines:
"A class containing witness computation helper functions used by OinkProver in UltraFlavor, MegaFlavor, and their derivatives"
There was a problem hiding this comment.
thanks for catching - had something to this effect in a commit that I just forgot to push - updated now
iakovenkos
reviewed
Jan 13, 2025
| @@ -0,0 +1,35 @@ | |||
| #pragma once | |||
There was a problem hiding this comment.
thanks for adding this class, it really helps to reduce noise in some of our tests
iakovenkos
approved these changes
Jan 13, 2025
TomAFrench
added a commit
that referenced
this pull request
Jan 13, 2025
* master: (329 commits) fix(avm): mac build (#11195) fix: docs rebuild patterns (#11191) chore: refactor Solidity Transcript and improve error handling in sol_honk flow (#11158) chore: move witness computation into class plus some other cleanup (#11140) fix: get_next_power_exponent off by 1 (#11169) chore(avm): vm2 followup cleanup (#11186) fix: underconstrained bug (#11174) refactor: VariableMerkleTree readability improvements (#11165) chore: removing noir bug workaround (#10535) chore(docs): Remove node pages (#11161) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits git subrepo push --branch=master barretenberg feat(avm2): avm redesign init (#10906) feat: Sync from noir (#11138) feat: simulator split (#11144) chore: rpc server cleanup & misc fixes (#11145) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor cleanup/refactor of Flavor logic (particularly MegaFlavor). Mostly deleting unused methods and moving that did not strictly belong in the Flavor to new classes
WitnessComputationandMegaMemoryEstimator