fix: bump lookup table constant and improve logging #11095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasxia01
approved these changes
Jan 7, 2025
| @@ -23,7 +23,13 @@ void construct_lookup_table_polynomials(const RefArray<typename Flavor::Polynomi | |||
| // ignored, as used for regular constraints and padding to the next power of 2. | |||
| // TODO(https://github.com/AztecProtocol/barretenberg/issues/1033): construct tables and counts at top of trace | |||
| const size_t tables_size = circuit.get_tables_size(); | |||
| ASSERT(tables_size <= MAX_LOOKUP_TABLES_SIZE); // if false, may need to increase constant | |||
There was a problem hiding this comment.
was this assert previously not being triggered?
There was a problem hiding this comment.
In debug it would but otherwise I think not. Just rearranged so that theres some warning in release
saleel
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the MAX_LOOKUP_TABLES_SIZE constant (for now) to avoid pain for developers. Added TODO to reconsider this in the future to continue to benefit from the memory gains afforded by MAX_LOOKUP_TABLES_SIZE