feat: 7 bit long note_type_id
#10951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benesjan
force-pushed
the
12-23-feat_7_bit_long_note_type_id
branch
from
9ea4e28 to
dc769f2
Compare
benesjan
commented
Dec 23, 2024
benesjan
force-pushed
the
12-23-feat_7_bit_long_note_type_id
branch
from
74f25be to
3378d22
Compare
benesjan
commented
Jan 2, 2025
| @@ -265,7 +266,7 @@ pub(crate) comptime fn generate_note_export( | |||
| let mut hasher = Poseidon2Hasher::default(); | |||
| s.as_type().hash(&mut hasher); | |||
| let hash = hasher.finish() as u32; | |||
| let global_export_name = f"{name}_{hash}_EXPORTS".quoted_contents(); | |||
| let global_export_name = f"{name}_EXPORTS_{hash}".quoted_contents(); | |||
There was a problem hiding this comment.
Sneaked in this change as it did not follow the docs on line 249.
nventuro
approved these changes
Jan 8, 2025
noir-projects/noir-contracts/contracts/test_contract/src/test.nr
Outdated
Show resolved
Hide resolved
benesjan
force-pushed
the
12-23-feat_7_bit_long_note_type_id
branch
from
5c4c5ad to
96033d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making note type id 7 bits long.