feat: PXE db contract store #10867
Merged
feat: PXE db contract store #10867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benesjan
force-pushed
the
12-18-feat_pxe_db_contract_store
branch
3 times, most recently
from
f1828dc to
1468edf
Compare
benesjan
commented
Dec 19, 2024
nventuro
reviewed
Dec 19, 2024
noir-projects/noir-contracts/contracts/test_contract/src/main.nr
Outdated
Show resolved
Hide resolved
benesjan
force-pushed
the
12-18-feat_pxe_db_contract_store
branch
4 times, most recently
from
238247f to
127f26d
Compare
benesjan
force-pushed
the
12-18-feat_pxe_db_contract_store
branch
4 times, most recently
from
111fea9 to
1d2256b
Compare
benesjan
force-pushed
the
12-18-feat_pxe_db_contract_store
branch
from
ed04629 to
c96105e
Compare
benesjan
commented
Jan 7, 2025
benesjan
commented
Jan 7, 2025
nventuro
approved these changes
Jan 8, 2025
Comment on lines
+20
to
+28
| /// Load data from local PXE database. We pass in `t_size` as a parameter to have the information of how many fields | ||
| /// we need to pad if the key does not exist (note that the actual response size is `t_size + 1` as the Option prefixes | ||
| /// the response with a boolean indicating if the data exists). | ||
| /// | ||
| /// Note that we need to return an Option<[Field; N]> as we cannot return an Option<T> directly. This is because then | ||
| /// the shape of T would affect the expected oracle response (e.g. if we were returning a struct of 3 u32 values | ||
| /// then the expected response shape would be 3 single items. If instead we had a struct containing | ||
| /// `u32, [Field;10], u32`, then the expected shape would be single, array, single.). | ||
| #[oracle(load)] |
There was a problem hiding this comment.
This is very clear, thanks for the writeup.
Co-authored-by: Nicolás Venturo <[email protected]>
Changes to circuit sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10730
+ adds support for non-flat return values in oracle.ts (TXE supported this but PXE did not)