chore: use L1 Tx Utils #10759
chore: use L1 Tx Utils #10759
Conversation
| const args = [to.toString(), amount, claimSecretHash.toString()] as const; | ||
| const { request } = await this.portal.simulate.depositToAztecPublic(args); | ||
|
|
||
| const txReceipt = await this.l1TxUtils.sendAndMonitorTransaction( | ||
| { | ||
| to: request.address!, | ||
| data: encodeFunctionData({ | ||
| abi: this.portal.abi, | ||
| functionName: 'depositToAztecPublic', | ||
| args, | ||
| }), | ||
| }, | ||
| { | ||
| fixedGas: request.gas, | ||
| }, | ||
| ); |
There was a problem hiding this comment.
Do we need to call simulate here if the tx utils already call estimateGas under the hood, which should throw (emphasis on should, we need to verify that) if the tx would revert? Also, note that simulate does not seem to perform a gas estimation as it's just mapped to call, and the gas returned seems to be whatever was originally set and not the actual gas used (see here).
| // Call function on L1 contract to consume the message | ||
| const { request } = await this.portal.simulate.withdraw(withdrawArgs); |
| // Send transactions first | ||
| const [mintTxRes, approveTxRes] = await Promise.all([ | ||
| l1TxUtils.sendTransaction(mintRequest), | ||
| l1TxUtils.sendTransaction(approveRequest), | ||
| ]); | ||
|
|
||
| // Monitor transactions in parallel | ||
| await Promise.all([ | ||
| l1TxUtils.monitorTransaction(mintRequest, mintTxRes.txHash, { gasLimit: mintTxRes.gasLimit }), | ||
| l1TxUtils.monitorTransaction(approveRequest, approveTxRes.txHash, { gasLimit: approveTxRes.gasLimit }), | ||
| ]); |
There was a problem hiding this comment.
Curious: why not a single Promise.all with sendAndMonitor?
There was a problem hiding this comment.
I feel like I had a reason and now realizing that it was probably invalid since we're sending these 2 at the same time anyway
Changes to circuit sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
Fixes #10464