Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prover] Clean up configuration split across multiple packages #10269

Open
Tracked by #8495
alexghr opened this issue Nov 28, 2024 · 0 comments
Open
Tracked by #8495

[Prover] Clean up configuration split across multiple packages #10269

alexghr opened this issue Nov 28, 2024 · 0 comments

Comments

@alexghr
Copy link
Contributor

alexghr commented Nov 28, 2024

The current prover-client config is split over multiple different components and packages. We should clean up the types and co-locate them in a single package to simplify imports and workspace dependencies

import { type ACVMConfig, type BBConfig } from '@aztec/bb-prover';
import {
  type ProverAgentConfig,
  type ProverBrokerConfig,
  type ProverConfig,
} from '@aztec/circuit-types';

export type ProverClientConfig = ProverConfig & ProverAgentConfig & ProverBrokerConfig & BBConfig & ACVMConfig;

As part of this change also use the ProverBrokerConfig in the ProvingBroker class (see comment):

class ProvingBroker {
  public constructor(
    private database: ProvingBrokerDatabase,
    { jobTimeoutMs = 30, timeoutIntervalMs = 10, maxRetries = 3 }: ProofRequestBrokerConfig = {}, // <=== this type is a duplicate and we should get rid of it
    private logger = createDebugLogger('aztec:prover-client:proving-broker'),
  ) {}
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant