feat(avm): new public inputs witgen #10179

IlyasRidhuan · 2024-11-25T14:34:33Z

This PR does a few things

Disconnects the kernel trace constraints (but keeps the file for future reference when we re-constrain public inputs)
Replaces the old public inputs with the new ones from AvmCircuitPublicInputs, however unconstrained
All merkle checks are now performed in witgen

It's still a bit brittle and probably needs a refactor to clean it up but will suffice for now as we are getting all the pieces together

IlyasRidhuan · 2024-11-25T14:34:49Z

feat(avm): new public inputs witgen #10179 👈 (View in Graphite)
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

IlyasRidhuan · 2024-11-25T17:30:37Z

barretenberg/cpp/pil/avm/main.pil

@@ -16,6 +16,17 @@ include "gadgets/mem_slice.pil";
 include "gadgets/merkle_tree.pil";

 namespace main(256);
+    //===== PUBLIC INPUT POLYNOMIALS ======================================


These are moved over to just keep the existing public inputs structure and is not representative of the final version

Were these copied from another PIL file? Should they be removed from their original file?

yeah - the old pil file (kernel.pil) is commented out - it will eventually be deleted entirely, but ive kept it because we will need to reference / copy stuff from it when we constrain the new inputs

IlyasRidhuan · 2024-11-25T17:31:48Z

barretenberg/cpp/src/barretenberg/vm/avm/trace/gadgets/poseidon2.hpp

@@ -13,6 +13,7 @@ enum Poseidon2Caller {
    NONE = 0,
    BYTECODE_HASHING = 1,
    MERKLE_TREE = 2,
+    SILO = 3,


These will be used when we constrain silo-ing in the circuit

IlyasRidhuan · 2024-11-25T17:32:11Z

barretenberg/cpp/src/barretenberg/vm/avm/trace/gadgets/merkle_tree.hpp

@@ -12,7 +14,7 @@ class AvmMerkleTreeTraceBuilder {
    struct MerkleEntry {
        uint32_t clk;
        FF leaf_value{};
-        uint32_t leaf_index;
+        uint64_t leaf_index;


2^40 trees at this stage require bigger indices

dbanks12

Looks good! Handful of comments. I'd expect all the merkle checks in witgen to break for transactions that include side effects from private since (i think) you aren't inserting any of the stuff from private, so the start and end roots should be mismatched. How is this working?

dbanks12 · 2024-11-25T22:36:33Z

barretenberg/cpp/pil/avm/main.pil

@@ -16,6 +16,17 @@ include "gadgets/mem_slice.pil";
 include "gadgets/merkle_tree.pil";

 namespace main(256);
+    //===== PUBLIC INPUT POLYNOMIALS ======================================


Were these copied from another PIL file? Should they be removed from their original file?

dbanks12 · 2024-11-25T22:40:29Z

barretenberg/cpp/src/barretenberg/vm/avm/tests/execution.test.cpp

-        return AvmExecutionTests::gen_trace(bytecode, calldata, public_inputs_vec, returndata, execution_hints);
+        auto p_i = public_inputs;
+        return AvmExecutionTests::gen_trace(bytecode, calldata, p_i, returndata, execution_hints);


nit: no need to rename to p_i here?

barretenberg/cpp/src/barretenberg/vm/avm/tests/execution.test.cpp

barretenberg/cpp/src/barretenberg/vm/avm/trace/trace.cpp

dbanks12 · 2024-11-25T23:43:13Z

barretenberg/cpp/src/barretenberg/vm/avm/trace/trace.hpp

+    // These are the tracked roots for intermediate steps
+    TreeSnapshots intermediate_tree_snapshots;
+    // These are some counters for the tree acceess hints that we probably dont need in the future
+    uint32_t note_hash_read_counter = 0;
+    uint32_t note_hash_write_counter = 0;
+    uint32_t nullifier_read_counter = 0;
+    uint32_t nullifier_write_counter = 0;
+    uint32_t l1_to_l2_msg_read_counter = 0;
+    uint32_t storage_read_counter = 0;
+    uint32_t storage_write_counter = 0;



We actually might need these in the future because we need to raise error flag if these surpass some limits.

yarn-project/simulator/src/avm/avm_tree.test.ts

IlyasRidhuan · 2024-11-26T15:25:54Z

yarn-project/aztec/docker-compose.yml

@@ -10,7 +10,7 @@ services:
        exec anvil --silent -p "$$ANVIL_PORT" --host 0.0.0.0 --chain-id 31337
      fi'
    ports:
-      - "${ANVIL_PORT:-8545}:${ANVIL_PORT:-8545}"
+      - '${ANVIL_PORT:-8545}:${ANVIL_PORT:-8545}'


some leftover formatting from master i think

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.65.0</summary> ## [0.65.0](aztec-package-v0.64.0...aztec-package-v0.65.0) (2024-11-26) ### Features * **avm:** New public inputs witgen ([#10179](#10179)) ([ac8f13e](ac8f13e)) </details> <details><summary>barretenberg.js: 0.65.0</summary> ## [0.65.0](barretenberg.js-v0.64.0...barretenberg.js-v0.65.0) (2024-11-26) ### Bug Fixes * **bb.js:** Don't minify bb.js - webpack config ([#10170](#10170)) ([6e7fae7](6e7fae7)) </details> <details><summary>aztec-packages: 0.65.0</summary> ## [0.65.0](aztec-packages-v0.64.0...aztec-packages-v0.65.0) (2024-11-26) ### ⚠ BREAKING CHANGES * remove SharedImmutable ([#10183](#10183)) * rename sharedimmutable methods ([#10164](#10164)) ### Features * **avm:** New public inputs witgen ([#10179](#10179)) ([ac8f13e](ac8f13e)) * Blobs. ([#9302](#9302)) ([03b7e0e](03b7e0e)) * One liner for nodes to join rough-rhino ([#10168](#10168)) ([3a425e9](3a425e9)) * Origin tags implemented in biggroup ([#10002](#10002)) ([c8696b1](c8696b1)) * Remove SharedImmutable ([#10183](#10183)) ([a9f3b5f](a9f3b5f)) * Rename sharedimmutable methods ([#10164](#10164)) ([ef7cd86](ef7cd86)) * UltraRollupRecursiveFlavor ([#10088](#10088)) ([4418ef2](4418ef2)) ### Bug Fixes * Aztec-nargo curl in the earthfile also ([#10199](#10199)) ([985a678](985a678)) * **bb.js:** Don't minify bb.js - webpack config ([#10170](#10170)) ([6e7fae7](6e7fae7)) * Docker compose aztec up fix ([#10197](#10197)) ([d7ae959](d7ae959)) * Increase test timeouts ([#10205](#10205)) ([195aa3d](195aa3d)) * Release l1-contracts ([#10095](#10095)) ([29f0d7a](29f0d7a)) * Revert "feat: blobs. ([#9302](#9302))" ([#10187](#10187)) ([a415f65](a415f65)) ### Miscellaneous * Added ref to env variables ([#10193](#10193)) ([b51fc43](b51fc43)) * **avm:** Operands reordering ([#10182](#10182)) ([69bdf4f](69bdf4f)), closes [#10136](#10136) * Fix devbox ([#10201](#10201)) ([323eaee](323eaee)) * Misc cleanup ([#10194](#10194)) ([dd01417](dd01417)) * Reinstate docs-preview, fix doc publish ([#10213](#10213)) ([ed9a0e3](ed9a0e3)) * Replace relative paths to noir-protocol-circuits ([1650446](1650446)) </details> <details><summary>barretenberg: 0.65.0</summary> ## [0.65.0](barretenberg-v0.64.0...barretenberg-v0.65.0) (2024-11-26) ### Features * **avm:** New public inputs witgen ([#10179](#10179)) ([ac8f13e](ac8f13e)) * Origin tags implemented in biggroup ([#10002](#10002)) ([c8696b1](c8696b1)) * UltraRollupRecursiveFlavor ([#10088](#10088)) ([4418ef2](4418ef2)) ### Miscellaneous * **avm:** Operands reordering ([#10182](#10182)) ([69bdf4f](69bdf4f)), closes [#10136](#10136) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

IlyasRidhuan force-pushed the ir/11-14-feat_avm_new_public_inputs_witgen branch 2 times, most recently from 4431f66 to d05ccb0 Compare November 25, 2024 17:17

IlyasRidhuan marked this pull request as ready for review November 25, 2024 17:28

IlyasRidhuan requested review from fcarreiro, dbanks12, jeanmon and Maddiaa0 as code owners November 25, 2024 17:28

IlyasRidhuan removed request for fcarreiro, dbanks12, Maddiaa0 and jeanmon November 25, 2024 17:28

IlyasRidhuan commented Nov 25, 2024

View reviewed changes

dbanks12 approved these changes Nov 25, 2024

View reviewed changes

IlyasRidhuan mentioned this pull request Nov 26, 2024

chore(avm): handle parsing error #10203

Merged

IlyasRidhuan force-pushed the ir/11-14-feat_avm_new_public_inputs_witgen branch from d05ccb0 to 7bbeeee Compare November 26, 2024 12:30

IlyasRidhuan added 3 commits November 26, 2024 12:31

feat(avm): new public inputs witgen

b645e4d

feat: add public call requests to loop

925acc7

feat: first pass removing old public inputs

dcdb3f0

IlyasRidhuan force-pushed the ir/11-14-feat_avm_new_public_inputs_witgen branch from 7bbeeee to dcdb3f0 Compare November 26, 2024 15:25

IlyasRidhuan commented Nov 26, 2024

View reviewed changes

IlyasRidhuan requested a review from jeanmon November 26, 2024 15:26

IlyasRidhuan merged commit ac8f13e into master Nov 26, 2024
74 checks passed

IlyasRidhuan deleted the ir/11-14-feat_avm_new_public_inputs_witgen branch November 26, 2024 17:32

AztecBot mentioned this pull request Nov 26, 2024

chore(master): Release 0.65.0 #10181

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(avm): new public inputs witgen #10179

feat(avm): new public inputs witgen #10179

IlyasRidhuan commented Nov 25, 2024 •

edited

Loading

IlyasRidhuan commented Nov 25, 2024

IlyasRidhuan Nov 25, 2024

dbanks12 Nov 25, 2024

IlyasRidhuan Nov 26, 2024

IlyasRidhuan Nov 25, 2024

IlyasRidhuan Nov 25, 2024

dbanks12 left a comment

dbanks12 Nov 25, 2024

dbanks12 Nov 25, 2024

dbanks12 Nov 25, 2024

IlyasRidhuan Nov 26, 2024

feat(avm): new public inputs witgen #10179

feat(avm): new public inputs witgen #10179

Conversation

IlyasRidhuan commented Nov 25, 2024 • edited Loading

IlyasRidhuan commented Nov 25, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dbanks12 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

IlyasRidhuan commented Nov 25, 2024 •

edited

Loading