From fe4484a8b9eeb3c997650e94794b0db3b4f4e404 Mon Sep 17 00:00:00 2001
From: Santiago Palladino <santiago@aztecprotocol.com>
Date: Wed, 4 Oct 2023 17:30:18 -0300
Subject: [PATCH] fix: Remove npx from extract_tag_version (#2697)

Removes npx from `extract_tag_version`, so it can be safely called from
the base aztec alpine build image, so it doesn't fail when called from
the `build` script.

Manually run tests:
```
$ COMMIT_TAG=v0.8.7 ./scripts/extract_tag_version foo
0.8.7
$ COMMIT_TAG=0.8.7 ./scripts/extract_tag_version foo
0.8.7
$ COMMIT_TAG=repo/v0.8.7 ./scripts/extract_tag_version foo
Tag was made for: repo
Version: v0.8.7
REPO_NAME (repo) does not match REPOSITORY (foo). Exiting...
$ COMMIT_TAG=foo/v0.8.7 ./scripts/extract_tag_version foo
Tag was made for: foo
Version: v0.8.7
0.8.7
$ COMMIT_TAG=foo/v0.8.7 ./scripts/extract_tag_version foo
Tag was made for: foo
Version: v0.8.7
0.8.7
$ COMMIT_TAG=foo/0.8.7 ./scripts/extract_tag_version foo
Tag was made for: foo
Version: 0.8.7
0.8.7
$ COMMIT_TAG=foo/notsemver ./scripts/extract_tag_version foo
Tag was made for: foo
Version: notsemver
notsemver is not a semantic version.

$ COMMIT_TAG=notsemver ./scripts/extract_tag_version foo
notsemver is not a semantic version.

$ COMMIT_TAG=0.8.7 ./scripts/extract_tag_version foo
0.8.7
$ COMMIT_TAG=v0.8.7 ./scripts/extract_tag_version foo
0.8.7
$ COMMIT_TAG=v0.8.7-alpha1 ./scripts/extract_tag_version foo
0.8.7-alpha1
```
---
 build-system/scripts/extract_tag_version | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/build-system/scripts/extract_tag_version b/build-system/scripts/extract_tag_version
index 43151389717..d142458104d 100755
--- a/build-system/scripts/extract_tag_version
+++ b/build-system/scripts/extract_tag_version
@@ -41,14 +41,14 @@ if [[ "$COMMIT_TAG" == *"/"* ]]; then
 fi
 
 # Check it's a valid semver.
-VERSION=$(npx semver "$COMMIT_TAG_VERSION")
-if [[ -z "$VERSION" ]]; then
+SEMVER_REGEX="^v?([0-9]+)\.([0-9]+)\.([0-9]+)(-([0-9A-Za-z-]+(\.[0-9A-Za-z-]+)*))?(\+([0-9A-Za-z-]+(\.[0-9A-Za-z-]+)*))?$"
+if ! [[ $COMMIT_TAG_VERSION =~ $SEMVER_REGEX ]]; then
   echo "$COMMIT_TAG_VERSION is not a semantic version." >&2
   if [[ "$ERROR_ON_FAIL" == "true" ]]; then
     exit 1
   else
-    VERSION=""
+    COMMIT_TAG_VERSION=""
   fi
 fi
 
-echo "$VERSION"
+echo "${COMMIT_TAG_VERSION#v}"