From bb1fb907c74894b2a4ed571fd60ea043020a79be Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20Bene=C5=A1?= Date: Tue, 26 Sep 2023 13:21:28 +0200 Subject: [PATCH] fix: bootstrap.sh (#2524) Running bootstrap.sh on a freshly cloned repo failed with: image The issue is that the `circuits.in.ts` is dependent on `foundation` package but we do not build it before remaking the bindings. # Checklist: Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge. - [ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag. - [ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code. - [ ] Every change is related to the PR description. - [ ] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to relevant issues (if any exist). --- yarn-project/bootstrap.sh | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/yarn-project/bootstrap.sh b/yarn-project/bootstrap.sh index ebff8223db1..81b933d0bf7 100755 --- a/yarn-project/bootstrap.sh +++ b/yarn-project/bootstrap.sh @@ -16,18 +16,18 @@ set -eu yarn install --immutable -# Run remake bindings before building Aztec.nr contracts or l1 contracts as they depend on files created by it. -yarn --cwd circuits.js remake-bindings -yarn --cwd circuits.js remake-constants - # Build the necessary dependencies for Aztec.nr contracts typegen. -for DIR in foundation noir-compiler circuits.js; do +for DIR in foundation noir-compiler; do echo "Building $DIR..." cd $DIR yarn build cd .. done +# Run remake bindings before building Aztec.nr contracts or l1 contracts as they depend on files created by it. +yarn --cwd circuits.js remake-bindings +yarn --cwd circuits.js remake-constants + (cd noir-contracts && ./bootstrap.sh) (cd .. && l1-contracts/bootstrap.sh)