From a2d556cd249d3cc723ee8b5554c070a5f1e9bf53 Mon Sep 17 00:00:00 2001 From: IlyasRidhuan Date: Fri, 6 Dec 2024 15:38:58 +0000 Subject: [PATCH] fix: clean up old comments --- .../cpp/src/barretenberg/vm/avm/trace/trace.cpp | 15 --------------- .../cpp/src/barretenberg/vm/avm/trace/trace.hpp | 1 - 2 files changed, 16 deletions(-) diff --git a/barretenberg/cpp/src/barretenberg/vm/avm/trace/trace.cpp b/barretenberg/cpp/src/barretenberg/vm/avm/trace/trace.cpp index 5416cce3bf4..5f4cb69cc78 100644 --- a/barretenberg/cpp/src/barretenberg/vm/avm/trace/trace.cpp +++ b/barretenberg/cpp/src/barretenberg/vm/avm/trace/trace.cpp @@ -3465,7 +3465,6 @@ AvmError AvmTraceBuilder::constrain_external_call(OpCode opcode, // We keep the first encountered error AvmError error = AvmError::NO_ERROR; auto clk = static_cast(main_trace.size()) + 1; - // const ExternalCallHint& hint = execution_hints.externalcall_hints.at(external_call_counter); auto [resolved_addrs, res_error] = Addressing<5>::fromWire(indirect, call_ptr) @@ -3532,20 +3531,6 @@ AvmError AvmTraceBuilder::constrain_external_call(OpCode opcode, pc += Deserialization::get_pc_increment(opcode); - // Crucial to perform this operation after having incremented pc because write_slice_to_memory - // is implemented with opcodes (SET and JUMP). - // Write the success flag to memory - // write_to_memory(resolved_success_offset, hint.success, AvmMemoryTag::U1); - // external_call_counter++; - - // Save return data for later. - // nested_returndata = hint.return_data; - - // Adjust the side_effect_counter to the value at the end of the external call but not static call. - // if (opcode == OpCode::CALL) { - // side_effect_counter = static_cast(hint.end_side_effect_counter); - // } - // // We push the current ext call ctx onto the stack and initialize a new one current_ext_call_ctx.last_pc = pc; current_ext_call_ctx.success_offset = resolved_success_offset, diff --git a/barretenberg/cpp/src/barretenberg/vm/avm/trace/trace.hpp b/barretenberg/cpp/src/barretenberg/vm/avm/trace/trace.hpp index c7debf06c17..218070e87ee 100644 --- a/barretenberg/cpp/src/barretenberg/vm/avm/trace/trace.hpp +++ b/barretenberg/cpp/src/barretenberg/vm/avm/trace/trace.hpp @@ -305,7 +305,6 @@ class AvmTraceBuilder { AvmMemTraceBuilder mem_trace_builder; AvmAluTraceBuilder alu_trace_builder; AvmBinaryTraceBuilder bin_trace_builder; - // AvmKernelTraceBuilder kernel_trace_builder; AvmGasTraceBuilder gas_trace_builder; AvmConversionTraceBuilder conversion_trace_builder; AvmSha256TraceBuilder sha256_trace_builder;