Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KafkaPublisher should not be needed when you only want a fetcher. #306

Closed
gklijs opened this issue Jul 6, 2022 · 0 comments
Closed

KafkaPublisher should not be needed when you only want a fetcher. #306

gklijs opened this issue Jul 6, 2022 · 0 comments

Comments

@gklijs
Copy link

gklijs commented Jul 6, 2022

Enhancement Description

With additional configuration it should be possible to have a fetcher, consuming events from Kafka, without needing to configure a KafkaPublisher instance.

Current Behaviour

As KafkaPublisher is conditional, the KafkaAutoConfiguration won't do anything when it's not there.

Wanted Behaviour

Being able to have auto configuration when only using the fetcher.

Possible Workarounds

Either don't use auto configuration, or adding a KafkaPublisher (which will not be used).

Possible Solutions

It seems just removing @ConditionalOnClass(KafkaPublisher.class) will fix the issue. As there is already a kafkaPublisher defined inside I don't understand why it's in there. It seems like there is no good reason anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants