Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color escape codes are visible #131

Closed
dadav opened this issue Oct 25, 2024 · 5 comments · Fixed by #144
Closed

Color escape codes are visible #131

dadav opened this issue Oct 25, 2024 · 5 comments · Fixed by #144
Labels
bug Something isn't working shell
Milestone
v0.14

Comments

@dadav
Copy link

dadav commented Oct 25, 2024 •
edited
Loading

I'm using the kitty terminal and when I write MATCH (d:D it turns to MATCH ([33md:D. Is it possible to disable colors in the shell?
@AvitalTamir
Copy link
Owner

AvitalTamir commented Oct 26, 2024 •
edited
Loading

Hey @dadav thanks for reporting!
Will test this out with kitty and add no-color mode support, regardless.

@AvitalTamir AvitalTamir added bug Something isn't working shell labels Oct 26, 2024
@AvitalTamir AvitalTamir added this to the v0.14 milestone Oct 26, 2024
@naorpeled
Copy link
Collaborator

Hey @AvitalTamir and @dadav,
I'd like to take this 🙏

@AvitalTamir
Copy link
Owner

Thanks @naorpeled! let me know if you need anything.

@AvitalTamir
Copy link
Owner

In addition to a --no-color flag, we should also add support for NO_COLOR

@naorpeled
Copy link
Collaborator

naorpeled commented Nov 4, 2024 •
edited
Loading

In addition to a --no-color flag, we should also add support for NO_COLOR

Planning on implementing today/tomorrow,
already managed to reproduce using kitty terminal

will keep you posted 🙏

@naorpeled naorpeled mentioned this issue Nov 5, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working shell
Projects
None yet
Milestone
v0.14
Development

Successfully merging a pull request may close this issue.

feat(shell): support no color mode naorpeled/cyphernetes
3 participants
@naorpeled @dadav @AvitalTamir