Support dots and slashes in extra filters

[yndai]

Hi, first of all, really like this tool!

One use case I have is to filter on an annotation with dots an slashes, but I don't think this is supported? Please correct me if I'm wrong. For example something like:

MATCH (d:Deployment)
WHERE d.metadata.annotations.meta\.helm\.sh/release-name="my-app"
RETURN d.metadata.name;

results in a parse error: Error: unexpected $end Error >> error parsing query >> parsing failed

I also tried some variations of brackets and quotes, but they don't seem to return any results:

...
WHERE d.metadata.annotations[meta.helm.sh/release-name]="my-app"
...

I saw that this is supported in label matching: #99, but I don't believe this works for annotations.

[AvitalTamir]

Hi @yndai thanks for reporting! Indeed, we need to support this probably using escape slashes.

Good catch, this is an important one.

[AvitalTamir]

Resolved in #114

[reitzig]

I have a hard time extracting the supported syntax from #114, and LANGUAGE.md doesn't seem to mention escaping.

Is this what should work?

MATCH (d:Deployment)
WHERE d.metadata.annotations.meta\.helm\.sh/release-name="my-app"
RETURN d.metadata.name;

Because I'm getting

An error occurred while executing the query: Error: Error parsing query: parse error: parsing first clause: expected operator, got "\"

with v0.15.3.

Pre-emptive follow-up: I came here looking for how to do this:

MATCH (d:Deployment {namespace: "my-namespace"})
RETURN d.metadata.annotations.meta\.helm\.sh/release-name;

to feed into helm uninstall. Is the same escaping already supported for RETURN?

[AvitalTamir]

Hey @reitzig, thanks for reporting this!
the syntax is correct - this looks like a regression on our part from a recent parser rewrite.
I'll put out a patch and tests for this and also document escaping in the language doc, will release asap.

[AvitalTamir]

FYI PR is ready, we'll push out a new release in a couple of hours
#190

[reitzig]

Whoa, that was fast, thanks a bunch! 💚

[AvitalTamir]

@reitzig thank YOU for reporting!