-
-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it a requirement to have SwiftLint setup locally #58
Comments
Hey @AvdLee, I'm curious about what options are available in order to integrate SwiftLint. What approach are you thinking, creating an Xcode project and using a build phase? |
Exactly! The example project is already using SwiftLint but it's not failing if SwiftLint is not installed. We should change that to make sure that the coding guidelines are respected. |
That's interesting, because by creating an Xcode project file we should also be able to tackle this issue related to Carthage support 😅 |
This issue is stale because it has been open for 30 days with no activity. Remove the Stale label or comment or this will be closed in 10 days. |
This will be fixed with the WeTransfer-iOS-CI update we're working on! |
The pull request #73 that closed this issue was merged and released as part of Release 1.0.0 🚀 |
Ideally, the project should fail to build if SwiftLint is not installed. This is to make sure that CI and local environment are triggering the same warnings.
The text was updated successfully, but these errors were encountered: