Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VectorEventArgs becomes internal in latest avalonia 11 #9668

Closed
squirrelfeng opened this issue Dec 10, 2022 · 4 comments
Closed

VectorEventArgs becomes internal in latest avalonia 11 #9668

squirrelfeng opened this issue Dec 10, 2022 · 4 comments

Comments

@squirrelfeng
Copy link

Before I could use new VectorEventArgs instance to create customer control event, like below. But now I cannot because it says VectorEventArgs is internal constructor. Is there an alternative solution? Thanks!

var arg = new VectorEventArgs
{
Handled = e.Handled,
Route = e.Route,
RoutedEvent = MovedFinishedEvent,
Source = e.Source,
Vector = e.Vector
};

@maxkatz6 maxkatz6 removed the bug label Dec 10, 2022
@robloo
Copy link
Contributor

robloo commented Dec 10, 2022

@timunie
Copy link
Contributor

timunie commented Dec 11, 2022

Looks like we will revert this change as the impact was underestimated. If you have a free minute feel free to send us a PR making VectorEventArgs public again.

Have a nice Sunday

@hez2010
Copy link
Contributor

hez2010 commented Dec 16, 2022

Note that the missing constructors of various EventArgs also blocks the adoption from RyuJinx, see https://github.com/Ryujinx/Ryujinx/pull/3997

Some controls are broken due to certain EventArgs initializers being made private (Embedded Window on Windows broken)

@maxkatz6
Copy link
Member

It's public in latest master again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants