Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement NavigationDirection.Down/Up/Right/Left #8554

Closed
jinek opened this issue Jul 20, 2022 · 2 comments
Closed

Implement NavigationDirection.Down/Up/Right/Left #8554

jinek opened this issue Jul 20, 2022 · 2 comments
Labels
enhancement

Comments

@jinek
Copy link
Contributor

jinek commented Jul 20, 2022

KeyboardNavigationHandler only supports focusing with values NavigationDirection.Next/Previous, but throwing NotSupportedException for Down/Up/Right/Left.

Do we have any discussion going on about that?

As I see it's enough to enumerate everything focusable within same visual root and pickup the control which fits in coodrinates/geometry confitions.
I can take it for implementation.
@jinek jinek added the bug label Jul 20, 2022
@jinek
Copy link
Contributor Author

jinek commented Jul 22, 2022

I have tried this experimental code, it somehow works:
https://github.com/jinek/Consolonia/pull/79/files#diff-87edd463c680c3814584dca5b6b1069eea554e8f412169d00db01865270f0066R23

@maxkatz6 maxkatz6 added enhancement and removed bug labels Jul 23, 2022
@maxkatz6
Copy link
Member

Yes, there are discussions about it, #7607

Custom implementation of IKeyboardNavigationHandler should work fine with 0.10 avalonia as well.

@maxkatz6 maxkatz6 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maxkatz6 @jinek