Fix visual snapshot on headless #17565
Merged
+51
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
added
bug
area-headless
backport-candidate-11.2.x
kekekeks
approved these changes
Nov 20, 2024
|
You can test this PR using the following package version. |
maxkatz6
added a commit
that referenced
this pull request
Nov 26, 2024
* Check for HasRenderContextAffinity before calling CreateNonAffinedSnapshot * Add ServerVisualRenderContext.RenderChildren context parameter * Add Should_Render_To_A_Compositor_Snapshot_Capture test * Fix xunit tests
maxkatz6
added
backported-11.2.x
and removed
backport-candidate-11.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
CreateCompositionVisualSnapshotmethod on headless platform. Compositor checks forIDrawingContextLayerWithRenderContextAffinityImplinterface, but doesn't actually check forHasRenderContextAffinitybefore callingCreateNonAffinedSnapshot.ServerVisualRenderContext.RenderChildrenbool parameter.Checklist