Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build Clean target #17531

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Fix build Clean target #17531

merged 1 commit into from
Nov 19, 2024

Conversation

MrJul
Copy link
Member

@MrJul MrJul commented Nov 17, 2024

What does the pull request do?

This PR fixes the Clean build target:

  • It wasn't cleaning any of the bin/obj folders due to an incorrect glob (this probably worked in an older Nuke version).
  • It now also removes the node_modules folders.
  • It doesn't recreate the empty bin/obj folders immediately after deleting them.

@MrJul MrJul added bug area-infrastructure Issues related to CI/tooling infrastructur labels Nov 17, 2024
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.3.999-cibuild0053372-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 merged commit 29232ff into AvaloniaUI:master Nov 19, 2024
11 checks passed
@MrJul MrJul deleted the fix/build-clean branch November 19, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Issues related to CI/tooling infrastructur bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants