Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevTools] Allow Configure Inspect Hovered Control KeyBinding #15790

Closed
workgroupengineering opened this issue May 22, 2024 · 3 comments · Fixed by #16668
Closed

[DevTools] Allow Configure Inspect Hovered Control KeyBinding #15790

workgroupengineering opened this issue May 22, 2024 · 3 comments · Fixed by #16668

Comments

@workgroupengineering
Copy link
Contributor

Is your feature request related to a problem? Please describe.

When you have multiple keyboard layouts on Windows 10-11, the "CTRL-SHIFT" key combination is associated with the action of switching keyboard layouts. This does not allow you to use Inspect Hovered Control because it is binding to the same key combination.

Describe the solution you'd like

Allow configure InspectHoveredControl KeyBinding

Describe alternatives you've considered

No response

Additional context

No response

@stevemonaco
Copy link
Contributor

The main issues that caused me to punt on mutability of hotkeys (and why they weren't implemented in #15700 :

  1. There's no settings store for DevTools. This means in-app changes only last until the next debugging launch. You could configure in code, but that effects your entire team.
  2. There's no dialog system in DevTools, so that needs implemented or a workaround. In-place edits might be enough, but I do have other feature ideas where a small input dialog would be very useful. Any dialog needs to hidden from the DevTools Logical/Visual Trees, which https://github.com/AvaloniaUtils/DialogHost.Avalonia would support (being an overlay), but this doesn't warrant bringing in an external dependency, IMO.
  3. Not sure if the quality / naming is good enough for HotKeyConfiguration to be made public, so I left this part malleable for any future implementer.

@workgroupengineering
Copy link
Contributor Author

  1. There's no settings store for DevTools. This means in-app changes only last until the next debugging launch. You could configure in code, but that effects your entire team.

To solve this problem I load DevToolsOptions from appsettings.development.json

@workgroupengineering
Copy link
Contributor Author

Hi @maxkatz6,
Can I do a PR? Should I make this public or implement this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants