Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry.Combine() Incorrect Parameter Type #14369

Open
robloo opened this issue Jan 27, 2024 · 0 comments
Open

Geometry.Combine() Incorrect Parameter Type #14369

robloo opened this issue Jan 27, 2024 · 0 comments
Labels

Comments

@robloo
Copy link
Contributor

robloo commented Jan 27, 2024

Describe the bug

Geometry instead of RectangleGeometry should be used here:

public static Geometry Combine(Geometry geometry1, RectangleGeometry geometry2, GeometryCombineMode combineMode, Transform? transform = null)
{
return new CombinedGeometry(combineMode, geometry1, geometry2, transform);
}

To fix this as a non-breaking change we are going to have to add a new method and then obsolete the current one for removal in v12.

That said it probably should exist as a CombinedGeometry.Create() method rather than where it is today. However, it does follow WPF: https://learn.microsoft.com/en-us/dotnet/api/system.windows.media.geometry.combine?view=windowsdesktop-8.0

To Reproduce

See Avalonia source.

Expected behavior

A clear and concise description of what you expected to happen.

Screenshots

If applicable, add screenshots to help explain your problem.

Environment

  • OS: [e.g. Windows, Mac, Linux (State distribution), Android, iOS, Browser]
  • Avalonia-Version: [e.g. 11.x.y or 0.10.x]

Additional context

Add any other context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant