Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secret update proposal before launch #132

Open
chrisli30 opened this issue Feb 13, 2025 · 0 comments
Open

Secret update proposal before launch #132

chrisli30 opened this issue Feb 13, 2025 · 0 comments
Assignees
Labels
P2 Priority Level 2

Comments

@chrisli30
Copy link
Member

chrisli30 commented Feb 13, 2025

ListSecrets

Code reference:

message ListSecretsResp {

  1. List Request doesn’t allow an orgId input as other requests do.

Image

Create and Update Responses

Instead of boolean, Create and Update should return the updated object, so the caller doesn’t need to asssume it from its own input parameter.

The response would be,

{
  name: string;
  workflowId?: string;
  orgId?: string;
  createdAt: number;   // Could we add these two fields
  updatedAt: number;   // Could we add these two fields
}

@chrisli30 chrisli30 added the P1 Priority Level 1 label Feb 13, 2025
@chrisli30 chrisli30 added P1 Priority Level 1 P2 Priority Level 2 and removed P1 Priority Level 1 labels Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Priority Level 2
Projects
None yet
Development

No branches or pull requests

2 participants