Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the order in locale switcher to match the landing pages #96478

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

dlind1
Copy link
Contributor

@dlind1 dlind1 commented Nov 17, 2024

Related to #257-gh-Automattic/i18n-issues

Proposed Changes

Change the order of the locales in the language switcher to make it more intuitive.

Why are these changes being made?

The current list of locales is sorted by the locale code, which is not intuitive to our international users.
The rationale for the new ordering is: start with Latin-based ones sorted by locale code, followed by Cyrillic, Greek, RTL and CCJK locales, sorted by locale code within each group.

Testing Instructions

On calypso.live or locale instance open /themes and /plugins URLs and confirm that the order of the locales in the language switcher generally follows the order from wordpress.com or wordpress.com/pricing, with some changes: the addition of Greek and Romanian and English being at the top in /themes and /plugins.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • happy-blocks

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/language-switcher-order on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@dlind1 dlind1 marked this pull request as ready for review November 17, 2024 14:37
@dlind1 dlind1 requested review from alshakero and a team November 17, 2024 14:38
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 17, 2024
@dlind1 dlind1 merged commit 363aa88 into trunk Nov 17, 2024
17 checks passed
@dlind1 dlind1 deleted the fix/language-switcher-order branch November 17, 2024 14:42
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants