-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pattern Assembler - Improve pattern names, ordering and missing patterns #70323
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~253 bytes removed 📉 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Now I think something like the below is better
It's hard to understand the number suffix after the categories, |
Thanks for the feedback! The mapping from the pattern list can be found on the tooltip when hovering over a pattern. We are trying to avoid using IMO there is no need for the number suffix on I forgot to mention that the idea of using the categories is coming from this post. |
In my opinion, because otherwise, the experience will be inconsistent and the users will be even more confused why we have number suffixes in the content patterns. |
I actually like this version better because I can see the structure of my homepage better. Like, I can see that it consists of a CTA, a list, then an image pattern. 🥲 |
I think it depends on what we really want to solve. For me, calling it But if we're focusing on the structure of my homepage, then I agree the pattern name is great. However, when you're in the site editor and viewing the structure of your homepage (List View), it doesn't have any text related to the categories... |
You will still need to "count". For example, to find Pattern 28, you will need to count 28 patterns from the top. Unless we add names to the patterns in the pattern list... |
That's a fair point! But how about |
No, I mean, both of the solutions have that same problem, so we can't say that one is better than the other based on that argument alone. |
So, based on that, one possible alternative is to use |
One more thing is if we want to use the category, I'd prefer to show it somewhere instead of inside the tooltip. People might not be able to see something in the tooltip, so they might feel confused when they select a pattern. |
Related to WordPress/gutenberg#45595 |
We can close this issue and move the discussion to other channels. I've opened #70364 for the other pattern improvements. |
Proposed Changes
@taipeicoder, you were right about the need for translations.
Note:
The incremental number in the section pattern names is translated following the recommendation in i18n Calypso and the FG page i18n Best Practices for Hardcoded numbers, dates, currencies, coupons etc.
I had fun using a closure to increment the counter dinamically. I'm hoping reviewers will have fun too!
Pending tasks related to patterns for follow-up issues:
dotcomfsepatterns
todotcompatterns
and then add them in the PA.Blog
menu item to beAbout
in footersTesting Instructions
/setup?siteSlug=[ YOUR SITE ]
Pre-merge Checklist
Related to https://github.com/Automattic/dotcom-forge/issues/1251