-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GuidedTours: Add steps for site preview #5553
Conversation
From @mcsf:
|
705b868
to
2c83628
Compare
Rebased. |
Works well with responsive mode in Chrome for me! Nice. |
Yeah, I was quite surprised actually. |
4046e60
to
c0d8c37
Compare
Should we maybe just skip steps if the waiting function takes too long? |
We could end the tour if the wait is over 2-3 seconds, adding a |
Seems better. Plus maybe a notice for the user. |
LGTM. Squash and merge! |
@ehg checked on Firefox and Chrome on an Android device, I checked on Safari on an iPhone. All work fine. |
This adds a tour step that nudges the user to open their site's preview, and another one for closing it again. These steps are skipped if `preview-layout` is disabled. As part of this -- to guard against problems when there was no site selected, so that preview wouldn't work -- this also introduces a timeout for finding the next step's target, if there is one. If this takes longer than a few seconds, we end the tour gracefully, tell the user, and record a tracks event with an error message.
2c254a0
to
9a417d3
Compare
Closes #5120
Now that we're able to preview an iframed view of the current site by clicking on the current 'site card'…
…we want to modify the
main
tour to include steps to preview a site. This has the benefit of showing people their sites early on after signup.TODO:
Bump tour version(not here)Deploy in line with ABtest date/percentage change PR GuidedTours: Update MVP tour variants to 15% each #5450(not here)selectedSite
is availablenext: [ { 'config( 'preview-layout' )' : 'preview' }, { 'default': 'themes'} ]
To test:
DISABLE_FEATURES=preview-layout make run
— check http://calypso.localhost:3000/?tour=main doesn't include the preview stepsProps @lsinger @mcsf