Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update javascript doc to allow Array methods #26856

Merged
merged 3 commits into from
Aug 28, 2018
Merged

Docs: Update javascript doc to allow Array methods #26856

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f463fd
Docs: Update javascript doc to allow Array methods
sirbrillig Aug 23, 2018
719ddb1
Hide link url
sirbrillig Aug 24, 2018
b8ec0bb
Slightly adjust wording
sirbrillig Aug 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/coding-guidelines/javascript.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,7 +594,7 @@ We encourage you to make use of these methods in favor of traditional `for` and
- [`Array#some`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/some)
- [`Array#every`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/every)

While ES2015 and beyond include many more Array prototype methods, these cannot be used due to complications with polyfills. Instead, you are encouraged to use their [Lodash](https://lodash.com/) equivalents, among many other Lodash methods:
As of https://github.com/Automattic/wp-calypso/pull/25419, Calypso includes polyfills for many more Array prototype methods added in ES2015 and beyond. You can safely use them without fear of breaking in older browsers. If it's more convenient you can also use their [Lodash](https://lodash.com/) equivalents. For example:

- [`_.find`](https://lodash.com/docs/#find) ([`Array#find`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/find))
- [`_.findIndex`](https://lodash.com/docs/#findIndex) ([`Array#findIndex`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/findIndex))
Expand Down