Docs: Update javascript doc to allow Array methods #26856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since methods like `Array.includes()` are now able to be used safely in Calypso, this updates the documentation to explain that.
sirbrillig
force-pushed
the
update/js-array-methods-polyfill-doc
branch
from
59937f8 to
0f463fd
Compare
gwwar
added
Documentation
[Status] Needs Review
gwwar
approved these changes
Aug 23, 2018
There was a problem hiding this comment.
Thanks for updating documentation. This reads well, but we could maybe lessen the weight of the link a bit for the reader. Folks probably don't care as much about the historical context. For example:
Calypso [now](https://github.com/Automattic/wp-calypso/pull/25419) includes polyfills for many more Array prototype methods added in ES2015 and beyond ....
|
Good point @gwwar. |
gwwar
added
[Status] Ready to Merge
and removed
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since, as of #25419, methods like
Array.includes()are now able to be used safely in Calypso, this updates the documentation to explain that.