Fix/1275 disable disconnect link #2678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enejb
added
[Type] Enhancement
Jetpack
Jetpack Plugins
[Status] Needs Review
| @@ -48,6 +49,9 @@ export default React.createClass( { | |||
| scary: true, | |||
| onClick: ( event ) => { | |||
| event.preventDefault(); | |||
| if ( this.props.isMock ) { | |||
| return; | |||
There was a problem hiding this comment.
Could we not render the DisconnectJetpackButton component at all if isMock?
There was a problem hiding this comment.
Like you did for PluginInformation
There was a problem hiding this comment.
I think the idea is that we still want the toggles and the disconnect buttons visible. Since they show the possible actions when that would be available to the user.
There was a problem hiding this comment.
yup, the idea is to show the users what they are missing :)
lezama
added
[Status] Needs Author Reply
and removed
[Status] Needs Review
enejb
added
[Status] Needs Review
|
works great 👍 |
johnHackworth
added
[Status] Ready to Merge
and removed
[Status] Needs Review
enejb
force-pushed
the
fix/1275-disable-disconnect-link
branch
from
ca97cf8 to
a05193d
Compare
enejb
added a commit
that referenced
this pull request
Jan 26, 2016
…link Fix/1275 disable disconnect link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1275
Remove the ability to navigate to the disconnect link. Also remove the plugin info component if the plugin is display the mock version.
Prevents this from happening:
After: