Help: Fix contact form tool tips #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omarjackman
added
Live Chat
[Feature Group] Support
omarjackman
force-pushed
the
fix/contact-form-tool-tips
branch
from
50304ac to
f7ee720
Compare
omarjackman
added
the
[Status] Needs Review
| @@ -108,6 +108,10 @@ Boolean representing the selected visual state. `selected={ true }` creates a bl | |||
|
|
|||
| Optional URL to navigate to when option is clicked. | |||
|
|
|||
| `title` | |||
|
|
|||
| Optional title to show when hovering over segmented control options. | |||
There was a problem hiding this comment.
Might be good to mention that the child content of the item will be displayed unless this is specified.
|
I wonder if we need titles at all here, considering the content is already text. Visually it seems distracting and kinda pointless to just see repetition of the same text when you hover over an item. So I'd say 🚢 this to get the production issue fixed, but we should spend a little time to look into the repercussions of removing the title attribute entirely. |
rralian
added
[Status] Ready to Merge
and removed
[Status] Needs Review
…lp contact form. The titles will be the same as the labels.
omarjackman
force-pushed
the
fix/contact-form-tool-tips
branch
from
f7ee720 to
5d01f1e
Compare
omarjackman
added a commit
that referenced
this pull request
Dec 14, 2015
Help: Fix contact form tool tips
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #1433 by allowing
SegmentedControlsto use a custom title instead of the defaulttoStringthat is implicitly called on the child nodes for each option.How to test:
This requires you be in a group that has no available operators so that you can see the kayako ticket form
What to expect
Fixes #1433