Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Me: Fixes 2fa progress indicator layout on mobile #1441

Merged
merged 1 commit into from
Dec 9, 2015

Conversation

ebinnion
Copy link
Contributor

@ebinnion ebinnion commented Dec 9, 2015

Fixes #1440

Previously, the blue line on the 2fa progress indicator would expand outside of the gray lines of the card 😱 This PR fixes that.

cc @rickybanister and @enejb for what should be a quick review.

After screenshots:
screen shot 4
screen shot 5

Before screenshot:
3e8ef07a-9e74-11e5-8337-78c8869e446f

@ebinnion ebinnion added [Type] Bug [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR [Feature] User & Account Settings (/me) Settings and tools for managing your WordPress.com user account. labels Dec 9, 2015
@ebinnion ebinnion self-assigned this Dec 9, 2015
@rickybanister
Copy link

done! beautiful

@rickybanister rickybanister removed the [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR label Dec 9, 2015
ebinnion added a commit that referenced this pull request Dec 9, 2015
Me: Fixes 2fa progress indicator layout on mobile
@ebinnion ebinnion merged commit 96ef7d9 into master Dec 9, 2015
@ebinnion ebinnion deleted the fix/me-steps-header-mobile branch December 9, 2015 21:45
@scruffian scruffian removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] User & Account Settings (/me) Settings and tools for managing your WordPress.com user account. [Type] Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Me: 2fa steps doesn't stay within container
3 participants