Components: Adds LoggedOutFormContainer component #1284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebinnion
added
[Type] Question
[Status] Needs Review
| /** | ||
| * External dependencies | ||
| */ | ||
| import React from 'react';; |
There was a problem hiding this comment.
Extra semicolon here. Will remove as I continue to work on this.
ebinnion
force-pushed
the
try/logged-out-form-container
branch
from
222a71c to
2a20c66
Compare
|
This seems like a nice smart refactor. The only feedback I'd have is to change At this point Log In is so ubiquitous that it looks like a picture, not two words. Throwing the 'me' in the middle made it pretty funky to read (I know that's weird, but trust me) |
|
I'm going to ahead and cc @mtias for thoughts on factoring this out into a more global component. |
|
Closing in favor of #1521. |
scruffian
removed
the
[Status] Needs Review
lancewillett
removed
the
[Status] Needs Design Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to factor the logged out link that shows at the bottom of the form at
/start/account/userand to allow reuse of the logged out form styles, this PR refactors thesignup/logged-out-formcomponent and brings much of its functionality toclient/components/logged-out-form-containercomponent.At this point, I would like to solicit feedback from designers (cc @rickybanister) as well as devs ( cc @scruffian, @drewblaisdell, @lezama, @roccotripaldi ) to get feedback.
Questions:
logged-out-form-containerfor a component name. Do you have other suggestions?login-formscreenshot). Should single links be center aligned?While this PR is working, it should not be merged as it is a try PR and will require other work before it is ready to merge.
After screenshots: