Plans: Replace compare plans Noticon with Gridicon #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breezyskies
added
[Feature] Plans & Upgrades
|
Can we use size 18px instead of 16px (ideally 24px)? We're trying to standardize there :) Apart from that, looks good. 👍 |
folletto
removed
the
[Status] Needs Design Review
Updated. :) |
|
So much better! 👍 |
|
The code for this looks good to me. |
alternatekev
added
[Status] Ready to Merge
and removed
[Status] Needs Review
breezyskies
added a commit
that referenced
this pull request
Dec 4, 2015
Plans: Replace compare plans Noticon with Gridicon
| @@ -91,7 +92,8 @@ module.exports = React.createClass( { | |||
| href={ this.comparePlansUrl() } | |||
| className='plans-step__compare-plans-link' | |||
| onClick={ this.handleComparePlansLinkClick.bind( null, 'footer' ) }> | |||
| { this.translate( 'Compare Plans' ) } | |||
| <Gridicon icon="clipboard" size="18" /> | |||
There was a problem hiding this comment.
For good measure, the size prop should be passed as a number not a string: size={ 18 }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Side note: This should probably be componentized. cc: @scruffian