Themes: Install AT themes without -wpcom suffix #11608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AT sites no longer use -wpcom suffixes for wpcom themes. The intended plan was to still supply a suffix to the install endpoint for AT sites, but the Jetpack install endpoint has problems returning a different (non-suffixed) theme id to the one that was supplied. This change would require a modification to the wpcomsh plugin to not expect suffixed theme IDs.
seear
added
[Feature Group] Appearance & Themes
ockham
approved these changes
Feb 27, 2017
|
BTW, would be nice to cover this with a test (but unfortunately, I'm afraid we don't have the means to yet.) |
matticbot
removed
the
[Status] Needs Review
seear
added a commit
that referenced
this pull request
Feb 27, 2017
Apply install fix from #11608 to try&customize action now that Automated Transfer sites do not need the -wpcom suffix on theme IDs when installing themes.
This was referenced Feb 27, 2017
seear
added a commit
that referenced
this pull request
Feb 28, 2017
Apply install fix from #11608 to try&customize action now that Automated Transfer sites do not need the -wpcom suffix on theme IDs when installing themes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes theme activation and customization for AT sites.
AT sites no longer use -wpcom suffixes for wpcom themes. The intended plan for Calypso was to still supply a suffix to the install endpoint for AT sites (to avoid an AT special case), but the Jetpack install endpoint has problems returning a different (non-suffixed) theme id to the one that was supplied.
This change would require a modification to the wpcomsh plugin to not expect suffixed theme IDs.
This is an alternative to the workaround in #11535
/cc @lamosty