-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings: Update FormToggle to align to the top of the label #11237
Conversation
Vertical alignment of toggle looks great. Quick question, it appears that the margin between the main toggles and their labels vs the sub-toggles and their labels is different by about 4px, can you confirm and or fix that? |
You're right, it looks like we're setting the margin for JetpackModule toggles to 8px, while the others are 12px. Should it always be 12, or always be 8? |
I'd guess it should always be 12 if that style pre-dates the module toggles. @MichaelArestad does that make sense? |
Yeah. It should be 12, but we'll need to update the indent a bit to match so the child toggles line up with the module toggle's label. |
@MichaelArestad I'm not sure what you mean, can you tweak the CSS here (either as a commit to this PR or just drop in a comment)? |
@rickybanister @MichaelArestad #11240's been merged, taking care of the child toggle alignment - is this OK to merge now? |
Tested. Beautiful. Ready to merge. Thanks for tackling this! |
Fixes #10899
Toggles should now be aligned to the top line of the label when the label wraps:
To test:
@rickybanister @MichaelArestad