Site Settings: Add more settings Composing card for Jetpack sites #11231

tyxla · 2017-02-07T14:50:21Z

This PR implements After the Deadline settings for Jetpack sites in the Writing > Composing card. It also moves the current Markdown and Default Post Format settings in separate components in order to keep the main Composing card component clean. It also introduces a setFieldValue method to wrapSettingsForm that allows manually setting a specific field's value. The PR is part of #9171.

Preview (with collapsed Advanced settings):

Preview (with expanded Advanced settings):

To test:

Checkout this branch
Go to /settings/writing/$site where $site is one of your Jetpack sites.
Verify the default post format field works properly like before.
Verify the Markdown field is not displayed.
Play with the new After the Deadline settings (main toggle and sub settings) and verify they are stored and retrieved properly.
Go to /settings/writing/$site where $site is one of your WordPress.com sites.
Verify the default post format field works properly like before.
Verify the Markdown field works properly like before.
Verify the After the Deadline settings are not displayed for this site.

Styles here could benefit from #11240 - I can update the PR once it's merged.

matticbot · 2017-02-07T14:50:22Z

Test live: https://calypso.live/settings?branch=add/jetpack-settings-composing

a8ci18n · 2017-02-07T14:54:39Z

client/my-sites/site-settings/composing/after-the-deadline.jsx

+				<JetpackModuleToggle
+					siteId={ selectedSiteId }
+					moduleSlug="after-the-deadline"
+					label={ translate( 'Check your spelling, style, and grammar.' ) }


Hi! I've found a possible matching string that has already been translated 23 times:
translate( 'Spelling and Grammar' ) ES Score: 8.15

Help me improve these suggestions: react with 👎 if the suggestion doesn't make any sense, or with 👍 if it's a particularly good one (even if not implemented).

a8ci18n · 2017-02-07T14:54:39Z

client/my-sites/site-settings/composing/after-the-deadline.jsx

+					{ translate( 'English Options' ) }
+				</FormLegend>
+				<FormSettingExplanation>
+					{ translate( 'Enable proofreading for the following grammar and style rules:' ) }


Hi! I've found a possible matching string that has already been translated 40 times:
translate( 'Enable proofreading for the following grammar and style rules when writing posts and pages:' ) ES Score: 15.58

Help me improve these suggestions: react with 👎 if the suggestion doesn't make any sense, or with 👍 if it's a particularly good one (even if not implemented).

a8ci18n · 2017-02-07T14:54:40Z

client/my-sites/site-settings/composing/after-the-deadline.jsx

+					{ translate( 'Automatic Language Detection' ) }
+				</FormLegend>
+				<FormSettingExplanation>
+					{ translate( 'The proofreader supports English, French, German, Portuguese and Spanish.' ) }


Hi! I've found a possible matching string that has already been translated 19 times:
translate( 'The proofreader supports English, French, German, Portuguese, and Spanish. Your <a href="options-general.php">blog language</a> setting is the default proofreading language.' ) ES Score: 11.37

Help me improve these suggestions: react with 👎 if the suggestion doesn't make any sense, or with 👍 if it's a particularly good one (even if not implemented).

a8ci18n · 2017-02-07T14:54:40Z

client/my-sites/site-settings/composing/after-the-deadline.jsx

+
+				{
+					this.renderToggle( 'onupdate', ! afterTheDeadlineModuleActive, translate(
+						'A post or page is updated'


Hi! I've found a possible matching string that has already been translated 47 times:
translate( 'a post or page is updated' ) ES Score: 12.39

Help me improve these suggestions: react with 👎 if the suggestion doesn't make any sense, or with 👍 if it's a particularly good one (even if not implemented).

a8ci18n · 2017-02-07T14:54:40Z

client/my-sites/site-settings/composing/after-the-deadline.jsx

+
+				{
+					this.renderToggle( 'onpublish', ! afterTheDeadlineModuleActive, translate(
+						'A post or page is first published'


Hi! I've found a possible matching string that has already been translated 45 times:
translate( 'a post or page is first published' ) ES Score: 13.52

Help me improve these suggestions: react with 👎 if the suggestion doesn't make any sense, or with 👍 if it's a particularly good one (even if not implemented).

rickybanister · 2017-02-08T15:23:10Z

This looks good. I imagine the other PR to standardize the right-margin of toggles will take care of the misalignment here.

The only other thing I noticed was the lack of initial capitals on the first two proofreading settings:

All our other labels have an initial capital letter, we should standardize.

rickybanister · 2017-02-08T15:24:23Z

To follow up, if we don't like that those two labels start with a... we could change them to be plural:

Posts or pages are first published
Posts or pages are updated

tyxla · 2017-02-09T11:54:29Z

This looks good. I imagine the other PR to standardize the right-margin of toggles will take care of the misalignment here.

Yes - I'll make sure to do any necessary updates/cleanups here once that PR lands.

To follow up, if we don't like that those two labels start with a... we could change them to be plural:

Even better! I've updated the labels to the one you suggested.

@rickybanister do you feel there's anything else we should improve, design-wise? Also cc @MichaelArestad for a second opinion.

a8ci18n · 2017-02-09T11:55:52Z

client/my-sites/site-settings/composing/after-the-deadline.jsx

+
+				{
+					this.renderToggle( 'onupdate', ! afterTheDeadlineModuleActive, translate(
+						'Posts or pages are updated'


Hi! I've found a possible matching string that has already been translated 47 times:
translate( 'a post or page is updated' ) ES Score: 7.10

Help me improve these suggestions: react with 👎 if the suggestion doesn't make any sense, or with 👍 if it's a particularly good one (even if not implemented).

a8ci18n · 2017-02-09T11:55:52Z

client/my-sites/site-settings/composing/after-the-deadline.jsx

+
+				{
+					this.renderToggle( 'onpublish', ! afterTheDeadlineModuleActive, translate(
+						'Posts or pages are first published'


Hi! I've found a possible matching string that has already been translated 45 times:
translate( 'a post or page is first published' ) ES Score: 9.01

Help me improve these suggestions: react with 👎 if the suggestion doesn't make any sense, or with 👍 if it's a particularly good one (even if not implemented).

MichaelArestad · 2017-02-09T12:41:49Z

@tyxla We should hide the majority of those settings in an "Advanced options" section like we are doing in the feature/settings-overhaul branch of Jetpack:

tyxla · 2017-02-09T14:12:23Z

@MichaelArestad of course! Thanks for pointing that out. It's now implemented in 202a41a, I've also updated the previews in the PR description. Feel free to have another 👁 .

MichaelArestad · 2017-02-10T06:05:15Z

client/my-sites/site-settings/composing/style.scss

@@ -0,0 +1,7 @@
+.composing__module-settings.is-indented {
+	margin: 16px 32px 0;


Can we drop this in favor of the solution offered here: #11240

Yes, thanks for pointing that out. I've already added that to the description of the PR, and I'm planning to address it after it's merged.

@MichaelArestad this has been implemented in 76aa007.

tyxla · 2017-02-14T09:42:34Z

@rickybanister minor things addressed. A small preview of the updated version:

Feel free to have another look.

a8ci18n · 2017-02-14T09:44:16Z

client/my-sites/site-settings/composing/after-the-deadline.jsx

+				<JetpackModuleToggle
+					siteId={ selectedSiteId }
+					moduleSlug="after-the-deadline"
+					label={ translate( 'Check your spelling, style, and grammar' ) }


Hi! I've found a possible matching string that has already been translated 23 times:
translate( 'Spelling and Grammar' ) ES Score: 8.15

Help me improve these suggestions: react with 👎 if the suggestion doesn't make any sense, or with 👍 if it's a particularly good one (even if not implemented).

rickybanister · 2017-02-14T10:13:16Z

@tyxla beautiful, ship it.

folletto · 2017-02-14T10:23:04Z

Sorry if I missed this before, but wouldn't be better here to use our foldable card pattern instead of a link to open "Advanced settings"?

Something like this:

MichaelArestad · 2017-02-14T10:39:32Z

@folletto That's been brought up recently by @rickybanister as well. It's something we're definitely exploring, but this works and is good to merge for now.

…ttingsForm

…rases

…dline card

tyxla added Jetpack [Feature] Site Settings All other general site settings. [Status] In Progress labels Feb 7, 2017

tyxla added this to the Jetpack Module Settings in Calypso milestone Feb 7, 2017

tyxla self-assigned this Feb 7, 2017

oskosk mentioned this pull request Feb 7, 2017

Implement Jetpack Module Settings #9171

Closed

55 tasks

a8ci18n reviewed Feb 7, 2017

View reviewed changes

tyxla requested review from rickybanister, ryelle, oskosk, MichaelArestad, johnHackworth and roccotripaldi February 8, 2017 09:56

tyxla added [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Feb 8, 2017

tyxla force-pushed the add/jetpack-settings-composing branch from a610118 to 50e1091 Compare February 9, 2017 11:51

a8ci18n reviewed Feb 9, 2017

View reviewed changes

MichaelArestad reviewed Feb 10, 2017

View reviewed changes

tyxla force-pushed the add/jetpack-settings-composing branch from 76aa007 to c757244 Compare February 14, 2017 09:26

tyxla added [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR and removed [Status] Ready to Merge labels Feb 14, 2017

a8ci18n reviewed Feb 14, 2017

View reviewed changes

rickybanister added [Status] Ready to Merge and removed [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR labels Feb 14, 2017

tyxla added 15 commits February 14, 2017 12:09

Site Settings: Move wpcom markdown in a separate component

64cd119

Site Settings: Move default post format in a separate component

de0a737

Site Settings: Initial version of After the Deadline settings

c5837ca

Site Settings: Improve translations in AfterTheDeadline

07b4a47

Site Settings: Enable AfterTheDeadline only for supported sites

03e5679

Site Settings: Add support for manually setting field value in wrapSe…

861357c

…ttingsForm

Site Settings: Use TokenField instead of FormTextInput for ignored ph…

069f793

…rases

Site Settings: Rename MarkdownWpcom to just Markdown

d6e0292

Site Settings: Rename MarkdownWpcom to just Markdown

d38f21b

Site Settings: Improve wording in AfterTheDeadline labels

e7945c0

Site Settings: Cleanup unused props in Composing card

0adfaad

Site Settings: Implemenet advanced settings toggle in AfterTheDeadline

df98619

State: Add AfterTheDeadline settings to filterSettingsByActiveModules

14860b8

Site Settings: Update Composing styles as implemented in #11240

cd4e723

Site Settings: Formatting and alignment improvements in After The Dea…

cf4f59c

…dline card

tyxla force-pushed the add/jetpack-settings-composing branch from 40e77be to cf4f59c Compare February 14, 2017 11:09

tyxla merged commit 0f7e76b into master Feb 14, 2017

tyxla deleted the add/jetpack-settings-composing branch February 14, 2017 11:20

tyxla removed the [Status] Ready to Merge label Feb 14, 2017

oskosk mentioned this pull request Mar 1, 2017

Implement More Jetpack Module Settings #11676

Closed

48 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Site Settings: Add more settings Composing card for Jetpack sites #11231

Site Settings: Add more settings Composing card for Jetpack sites #11231

tyxla commented Feb 7, 2017 •

edited

Loading

matticbot commented Feb 7, 2017 •

edited by folletto

Loading

a8ci18n Feb 7, 2017 •

edited

Loading

a8ci18n Feb 7, 2017

a8ci18n Feb 7, 2017 •

edited

Loading

a8ci18n Feb 7, 2017

a8ci18n Feb 7, 2017

rickybanister commented Feb 8, 2017

rickybanister commented Feb 8, 2017

tyxla commented Feb 9, 2017

a8ci18n Feb 9, 2017 •

edited

Loading

a8ci18n Feb 9, 2017 •

edited

Loading

MichaelArestad commented Feb 9, 2017

tyxla commented Feb 9, 2017

MichaelArestad Feb 10, 2017

tyxla Feb 10, 2017

tyxla Feb 11, 2017

tyxla commented Feb 14, 2017

a8ci18n Feb 14, 2017

rickybanister commented Feb 14, 2017

folletto commented Feb 14, 2017

MichaelArestad commented Feb 14, 2017

		@@ -0,0 +1,7 @@
		.composing__module-settings.is-indented {
		margin: 16px 32px 0;

Site Settings: Add more settings Composing card for Jetpack sites #11231

Site Settings: Add more settings Composing card for Jetpack sites #11231

Conversation

tyxla commented Feb 7, 2017 • edited Loading

matticbot commented Feb 7, 2017 • edited by folletto Loading

a8ci18n Feb 7, 2017 • edited Loading

Choose a reason for hiding this comment

a8ci18n Feb 7, 2017

Choose a reason for hiding this comment

a8ci18n Feb 7, 2017 • edited Loading

Choose a reason for hiding this comment

a8ci18n Feb 7, 2017

Choose a reason for hiding this comment

a8ci18n Feb 7, 2017

Choose a reason for hiding this comment

rickybanister commented Feb 8, 2017

rickybanister commented Feb 8, 2017

tyxla commented Feb 9, 2017

a8ci18n Feb 9, 2017 • edited Loading

Choose a reason for hiding this comment

a8ci18n Feb 9, 2017 • edited Loading

Choose a reason for hiding this comment

MichaelArestad commented Feb 9, 2017

tyxla commented Feb 9, 2017

MichaelArestad Feb 10, 2017

Choose a reason for hiding this comment

tyxla Feb 10, 2017

Choose a reason for hiding this comment

tyxla Feb 11, 2017

Choose a reason for hiding this comment

tyxla commented Feb 14, 2017

a8ci18n Feb 14, 2017

Choose a reason for hiding this comment

rickybanister commented Feb 14, 2017

folletto commented Feb 14, 2017

MichaelArestad commented Feb 14, 2017

tyxla commented Feb 7, 2017 •

edited

Loading

matticbot commented Feb 7, 2017 •

edited by folletto

Loading

a8ci18n Feb 7, 2017 •

edited

Loading

a8ci18n Feb 7, 2017 •

edited

Loading

a8ci18n Feb 9, 2017 •

edited

Loading

a8ci18n Feb 9, 2017 •

edited

Loading