Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: display follow errors in the appropriate position #954

Closed
designsimply opened this issue Nov 29, 2015 · 3 comments
Closed

Reader: display follow errors in the appropriate position #954

designsimply opened this issue Nov 29, 2015 · 3 comments

Comments

@designsimply
Copy link
Contributor

Raised by @bluefuton

When a follow or unfollow error is encountered, we always show the error on the post card:

screen shot 2015-09-30 at 15 40 28

...and it persists in the full post view if the user doesn't dismiss it.

This sometimes feels a bit odd. We should perhaps store the origin of the follow, so we can display the error in the appropriate places.

Note from @designsimply

Error for reference:

Sorry, we couldn't follow this site. Please try again in a while. 
@blowery
Copy link
Contributor

blowery commented Dec 1, 2015

Need to determine if this is still a problem

@blowery blowery added this to the Reader: Feature Backlog milestone Dec 1, 2015
@blowery
Copy link
Contributor

blowery commented Dec 1, 2015

Yup, still a problem. Moving to feature backlog.

@alisterscott
Copy link
Contributor

The error notice seems to appear at the very top now regardless:

screen shot 2017-05-11 at 1 23 08 pm

And it doesn't seem to follow to full post view.

Closing this and we can raise a separate issue if the current display is not correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants