Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footnotes are saved in revisions in wp-admin but not Calypso #80933

Closed
cuemarie opened this issue Aug 22, 2023 · 8 comments
Closed

Footnotes are saved in revisions in wp-admin but not Calypso #80933

cuemarie opened this issue Aug 22, 2023 · 8 comments
Assignees
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. [Feature] Core Blocks Blocks that come with Gutenberg. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Platform] Atomic [Platform] Simple [Pri] Normal [Product] WordPress.com All features accessible on and related to WordPress.com. Revisions Triaged To be used when issues have been triaged. [Type] Feature Request Feature requests

Comments

@cuemarie
Copy link

Quick summary

Recently core added the ability to save/recover Footnotes in post revisions, but this is not happening in Calypso; the footnotes can only be recovered when working within wp-admin.

Steps to reproduce

  1. On a site with WP 6.3 and GB 16.4.0, Open Posts > Add New Post (https://wordpress.com/post/SITE_ADDRESS)
  2. Add content and multiple footnotes, and publish the post
  3. Make changes to the content and footnotes (i suggest changing the text in your footnotes so you can easily monitor changes) and Update
  4. Open Revisions and restore an older revision
    • Observe that the footnotes don't restore to the previous version
  5. Exit the post editor, and view the Posts page in Classic view, then edit your post (https://SITE_ADDRESS/wp-admin/post.php?post=POSTID&action=edit)
  6. Open Revisions here and view/restore older revisions
    • Observe that the footnotes are saved below the content, and restore alongside the content with a revision restore

Screenshots

wp-admin calypso
Markup on 2023-08-22 at 10:48:35 Markup on 2023-08-22 at 10:49:14

Recording from AT Site - comparing wp-admin (first) to calypso (second)

FgBoDd.mov

What you expected to happen

The footnotes to be restored with my revision when editing in Calypso.

What actually happened

Content restores but footnotes do not when editing in Calypso.

Impact

Some (< 50%)

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

Simple, Atomic

Logs or notes

Gutenberg Update: WordPress/gutenberg#52686
Core Changeset: https://core.trac.wordpress.org/changeset/56305/branches/6.3/src/wp-includes/blocks/footnotes.php

@cuemarie cuemarie added [Type] Bug [Pri] Normal [Type] Feature Request Feature requests Needs triage Ticket needs to be triaged [Product] WordPress.com All features accessible on and related to WordPress.com. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Feature] Core Blocks Blocks that come with Gutenberg. labels Aug 22, 2023
@cuemarie
Copy link
Author

📌 REPRODUCTION RESULTS

  • Tested on Simple – Replicated
  • Tested on Atomic – Replicated
  • Replicable outside of Dotcom – No

📌 ACTIONS

  • Shared here to see if anyone can pick this up: p1692738985042079-slack-C01LXBU1N21

@cuemarie cuemarie moved this from Needs Triage to To Do in Automattic Prioritization: The One Board ™ Aug 22, 2023
@cuemarie cuemarie added Triaged To be used when issues have been triaged. Revisions [Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. and removed Needs triage Ticket needs to be triaged labels Aug 22, 2023
@supernovia
Copy link
Contributor

Noting we've got a number of users who are getting "this block has encountered an error" type errors on the Footnotes block and can't get their footnotes back, so revisions would be very helpful in these cases.

@cuemarie
Copy link
Author

cuemarie commented Aug 24, 2023

@supernovia To help with those cases, if those block errors are new, then those users should be able to recover their footnotes via wp-admin already! (Posts > Classic View > Edit > Revisions) But if the block errors pre-date the GB updates that added Footnotes into revisions, that may not be possible

@aleone89
Copy link

Adding information from this thread: https://wordpress.com/forums/topic/the-new-footnotes/page/2/?view=all#post-3984692

When did you notice that the content went missing?

I saved a draft and they seemed to crash, not allowing me to put any more in and the block said it encountered an error trying to load footnotes. They were there to begin with, I edited them and added text and links. Now even after deleting all of them, saving the page as draft and reloading it, when I add a foot note it only comes up as an * and the footnote block doesn’t change

Also do you have any other posts or pages on your site that do have footnotes still? Or is this an issue with any footnotes on your site?

This was the first time I was using this feature.

I would be happy to upload my Javascript console if that would help you track down the error.

@cuemarie
Copy link
Author

Crossposted the escalation thread here as well: p1693424682170319-slack-C02DQP0FP

@filipanoscampos
Copy link

Another case: 7090491-zd-a8c

@github-actions
Copy link

github-actions bot commented Sep 27, 2023

Support References

This comment is automatically generated. Please do not edit it.

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Sep 27, 2023
@BogdanUngureanu BogdanUngureanu self-assigned this Aug 19, 2024
@BogdanUngureanu
Copy link
Contributor

Fixed in #93677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. [Feature] Core Blocks Blocks that come with Gutenberg. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Platform] Atomic [Platform] Simple [Pri] Normal [Product] WordPress.com All features accessible on and related to WordPress.com. Revisions Triaged To be used when issues have been triaged. [Type] Feature Request Feature requests
Development

No branches or pull requests

5 participants