Site Assembler - Patterns with maps don't render sometimes because the domReady is undefined

[miksansegundo]

What

Sometimes patterns with the block wp:jetpack/map don't render the map.

MAP ✅	MAP ❌

Why

Maybe the cause is that domReady is undefined.

How

• Explore the patterns in the category Contact, you should see four patterns with maps
• Find a fix for the domReady issue if that is the cause
• Check if it might be something related to the map style, because when the style is terrain the map uses Mapbox otherwise uses Apple maps. It doesn't seem related because both types are not rendered randomly.
  
  

[miksansegundo]

@arthur791004 where is the code that uses domReady?

[arthur791004]

Here. On production, it will try to get the value from window.wp.domReady

[miksansegundo]

I debugged it and found that the issue happens because the script wp-dom-ready is sometimes missing in the response of get_rendered_patterns.

WITH	WITHOUT

You can debug them using the pattern IDs with maps 10413, 5634, 280, 1397. I still don't know the root cause. Maybe you have ideas?

[miksansegundo]

Maybe there is an issue related to the dependency between wp-dom-ready and wp-polyfill that is injected via webpack. See dependency-extraction-webpack-plugin.

I found issues that explain about the polyfill dependency and how the map assets load in the editor:

• Photon: remove wp-dom-ready dependency jetpack#13624
• Map block: fix script loading to work with FSE jetpack#19552

[miksansegundo]

@Automattic/lego 🚨 It seems this issue is randomly affecting all patterns with Jetpack blocks.

I'm seeing this same issue in other patterns with the Jetpack blocks like jetpack/subscriptions and jetpack/recurring-payments.

You can reproduce it in the assembler by scrolling the list of patterns in the category Shop with the JS console open.

[miksansegundo]

I think it is random because the request /block-renderer/patterns/render receives multiple patterns and only the first pattern that requires wp-dom-ready will get it.

Maybe we have to requeue the assets for each pattern before running apply_filters( 'the_content', $pattern->html ).

See get_rendered_patterns fbhepr%2Skers%2Sjcpbz%2Sjc%2Qpbagrag%2Serfg%2Qncv%2Qcyhtvaf%2Sraqcbvagf%2Soybpx%2Qeraqrere%2Soybpx%2Qeraqrere%2Qcnggreaf.cuc%3Se%3Qo2n4r08s%2386-og

[miksansegundo]

🐛 Found it!! See D111593-code

[arthur791004]

Closing it as it's completed.