Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Style Changes are not reflected immediately on the live site #68893

Closed
devNigel opened this issue Oct 11, 2022 · 2 comments
Closed

Global Style Changes are not reflected immediately on the live site #68893

devNigel opened this issue Oct 11, 2022 · 2 comments
Labels

Comments

@devNigel
Copy link

Quick summary

After changing the font or other typography-related settings on Block themes, it was not reflected instantly. I was able to reproduce this issue on multiple themes like Zoologist, Livro, etc. I had to reload multiple times or clear browser cache to see the change.

Most users would not be familiar with clearing cache and it is not a good experience to have to clear cache every time a change it made in Global Styles.

I was able to reproduce it only on Simple sites.

Steps to reproduce

  1. Switch to an FSE theme.
  2. Go to Appearance > Editor > Global Styles
  3. Change different properties like Fonts, Letter case, etc and save it.
  4. You will notice you have to reload the site multiple times or manually clear the cache to see the changes.

What you expected to happen

Changes in Global Styles should be immediately reflected, without having to clear the cache.

What actually happened

Had to clear the cache and reload multiple times.

Context

No response

Platform (Simple, Atomic, or both?)

Simple

Theme-specific issue?

No response

Browser, operating system and other notes

No response

Reproducibility

Intermittent

Severity

No response

Available workarounds?

Yes, difficult to implement

Workaround details

Have to clear the cache, and reload multiple times. It is not easy to implement and is quite frustrating since you need to do it multiple times.

@devNigel devNigel added [Type] Bug [Pri] Normal Schedule for the next available opportuinity. User Report labels Oct 11, 2022
@zachspears
Copy link

Hey @devNigel, I was unable to reproduce this. Do you notice the issue in a particularly browser or theme?

@Copons
Copy link
Contributor

Copons commented Oct 13, 2022

I think this is related to either of these Core Guten issues:
WordPress/gutenberg#43914
WordPress/gutenberg#43395

There is indeed a small cache (1 minute, IIRC) on Global Styles.
It isn't often noticed while testing, because of how short it is and the number of things triggering a refresh (e.g. changing theme, just to name the most common).
The cache might also be bypassed when testing on the sandbox (at least I have never seen this issue, but was always a bit concerned about that cache while looking at the code. 🙂

I'll close this issue since it needs to be fixed from Core, but thanks for testing, investigating, and reporting! ✨

@Copons Copons closed this as not planned Won't fix, can't repro, duplicate, stale Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants