-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Premium Theme: Tsubaki #67862
Comments
|
I'm working on the demo site downgraded to a simple site https://tsubaki.wordpress.com at the moment for generating Headstart annotation. |
A diff for GlotPress project: D88714-code |
I've heard the idea that makes Tsubaki the default theme for Woo. With that and the guideline for themes to provide its homepage content has changed, so I need to make some changes to the theme before we launch the theme. Please continue to work on the issues with Headstart and Atomic but don't launch the theme yet. |
@mreishus @daledupreez I've merged the changes into the theme. Shall I wait to sync the theme in WP.com or can I just go a head? |
Please go ahead and then let me know. I'll then create a new annotation and regenerate the test site. |
I've deployed the theme. I've also realised that the deployment had no effect on the Atomic demo site, but I manually install the updated theme by uploading the theme. Anyway, the demo site looks good to go now. |
@iamtakashi, I wonder whether the issue with Atomic not updating is because we're not creating releases of the theme and/or not bumping the version. I have some questions about the way we handle managed themes on Atomic, so I will loop back on this topic tomorrow, hopefully with some helpful information! |
@daledupreez OK. Hopefully, we'll know the best way to update the theme in Atomic. I've actually realised something left to update, but the theme and the demo will be both ready by tomorrow. |
I'm done with the changes I needed to make. I expect minor updates will be made to the themes going forward. It's not a blocker for launch, but it'd be great if we could streamline the process of deploying the theme to Atomic and regenerating the Headspace annotation. |
I've created the annotation, bumped the version to I remember last time, I needed to manually specify Also, the buttons for New Arrival / Men / Women on the homepage no longer go anywhere. This is matching what I see on the demo site, but I think it worked better before? I also noticed it no longer has the auto loading homepage tag. This might be because it went from a homepage to a blog view, but it's something we might want anyway. Need to follow up on tomorrow. |
@mreishus, thanks for the update.
This was one of the changes I needed to make to the theme. The homepage content used to be built on a page that used the
This is also related to the change above. Now the homepage content is provided in the template, and the patterns that don't have any specific URLs (this is fine, and the patterns shouldn't have the specific URLs.)
I don't actually know what the tag means. Where was it used to be? |
@nelsonec87 is working on that issue in #69008 - the nav menus aren't working correctly at the moment. Also, can I request that we change from "Need a help?" to the simpler "Need help?" for the footer column? "Need help?" is a much more common/standard way of phrasing this in English. |
Thanks for pointing that out :) I'll change it asap! |
I've changed the heading. Thanks again for pointing this out. |
Theme is launched to all users! |
Details
The Tsubaki premium theme needs the following:
Checklist
Cheat sheet: paYKcK-1Pt-p2
Premium theme launch guide: PNEWy-eBM-p2
Related
No response
The text was updated successfully, but these errors were encountered: