Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSE: Larger site logo is not resized on smaller screens #64313

Closed
Gustavo-Hilario opened this issue Jun 2, 2022 · 3 comments
Closed

FSE: Larger site logo is not resized on smaller screens #64313

Gustavo-Hilario opened this issue Jun 2, 2022 · 3 comments
Labels
[Block] Site Logo [Pri] Normal Schedule for the next available opportuinity. Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended

Comments

@Gustavo-Hilario
Copy link

Quick summary

When using a larger Site Logo on a template, the logo isn't getting resized on smaller screens.

Steps to reproduce

  1. Activate the Blockbase theme or one of its children's themes.
  2. Add the Site Logo block to your template.
  3. On the editor resize the image to be larger than the normal viewport for mobile devices.
  4. Save the changes.
  5. Check your site on a mobile device.

What you expected to happen

I expected the logo to resize on smaller screens.

What actually happened

Apparently, the logo keeps the same size set on the editor.

Screenshot:

IMG_CCE5B0957705-1

Context

Customer report here: 5266202-zen

Simple, Atomic or both?

Simple, Atomic

Theme-specific issue?

I replicated this issue on the Blockbase theme, but also on its children's themes like Dorna and Hari.

Browser, operating system and other notes

No response

Reproducibility

Consistent

Severity

Some (< 50%)

Available workarounds?

Yes, easy to implement

Workaround details

There are two possible workarounds here:

1 – CSS code. This isn't ideal as the image might be distorted, but users can use this CSS code:

.custom-logo {
    max-width: 100%;
}

2 – Use an Image block instead of the Site Logo block. For this, users might want to add the home page link to their image.

@Gustavo-Hilario Gustavo-Hilario added [Type] Bug When a feature is broken and / or not performing as intended User Report labels Jun 2, 2022
@Gustavo-Hilario Gustavo-Hilario added [Pri] Normal Schedule for the next available opportuinity. [Block] Site Logo labels Jun 2, 2022
@Robertght
Copy link

📌 HOUSEKEEPING

  • Labels ✅
  • Priority ✅
  • Replicable on Core - Yes

📌 SCRUBBING

  • Tested on Simple ✅
  • Tested on AT ✅
  • Tested on Self-hosted ✅

📌 FINDINGS/SCREENSHOTS/VIDEO

  • Context: this is not theme specific. I noticed this happens with other FSE themes as well.

📌 ACTIONS

  • Marked as Triaged for Quality Squad review

@scruffian I found this PR WordPress/gutenberg#41298 - will this be available in Gutenberg 13.4?

@Robertght Robertght added the Triaged To be used when issues have been triaged. label Jun 5, 2022
@Robertght Robertght changed the title Blockbase: Larger site logo is not resized on smaller screens FSE: Larger site logo is not resized on smaller screens Jun 5, 2022
@scruffian
Copy link
Member

Yeah I think this is fixed by WordPress/gutenberg#41298

@mikeicode
Copy link

mikeicode commented Jun 8, 2022

I ran into this today using the theme Meraki, the resized logo was too large on mobile so I used CSS to set the max-width. pdEkSe-xG-p2

.custom-logo {
  max-width:100%;
  height:auto;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Site Logo [Pri] Normal Schedule for the next available opportuinity. Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

4 participants