Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Purchases: Use the correct site address in the URL #627

Closed
scruffian opened this issue Nov 24, 2015 · 3 comments
Closed

Purchases: Use the correct site address in the URL #627

scruffian opened this issue Nov 24, 2015 · 3 comments
Assignees
@drewblaisdell
Labels
[Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. [Type] Task

Comments

@scruffian
Copy link
Member

The manage purchase view always uses the *.wordpress.com site name in the url. It should be the primary domain as elsewhere in Calypso.

This was initially done in the REST API, but it caused issues with domain renewals in Jetpack sites. See r127299-wpcom.
@scruffian scruffian added [Type] Task [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. labels Nov 24, 2015
@scruffian scruffian added this to the Purchases: v1 milestone Nov 24, 2015
@umurkontaci umurkontaci self-assigned this Nov 24, 2015
@umurkontaci
Copy link
Contributor

This will be fixed with #536.

@umurkontaci umurkontaci added [Status] In Progress [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Nov 24, 2015
@drewblaisdell
Copy link
Contributor

This will be fixed soon in #536, but just so this information is stored on the issue instead of a PR: we should mirror the rest of Calypso by using the site slug as determined by SitesList instead of the primary domain, to handle this case.

@drewblaisdell
Copy link
Contributor

This was fixed by #536 and #1147.

@drewblaisdell drewblaisdell removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drewblaisdell drewblaisdell

Labels
[Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. [Type] Task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@scruffian @umurkontaci @drewblaisdell @fabianapsimoes