Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPT: Display notice after post actions succeed or fail #6104

Closed
aduth opened this issue Jun 16, 2016 · 5 comments
Closed

CPT: Display notice after post actions succeed or fail #6104

aduth opened this issue Jun 16, 2016 · 5 comments

Comments

@aduth
Copy link
Contributor

aduth commented Jun 16, 2016

Currently, there's no indication of success or failure when trashing a post from the custom post type listing screen. The post simply disappears. We should display a notice to inform the user whether their action succeeded or failed.

@nylen
Copy link
Contributor

nylen commented Jul 8, 2016

Related: #6306, #6536

The immediate disappearance of the post from the list is a bit jarring IMO - this could use an animation to make it more clear what is going on.

@aduth
Copy link
Contributor Author

aduth commented Jul 8, 2016

The immediate disappearance of the post from the list is a bit jarring IMO

Hmm, it may be possible to use React's CSSTransitionGroup component to apply a transition as the post is being removed from the list. I might even imagine a few variations of this to reflect the type of action taking place - a disappearing post on trash, a "stamp of approval" on publish. Maybe I'm getting a bit carried away 😄 cc @hugobaeta

@hugobaeta
Copy link

I think for now it should mimic whatever happens for Blog Posts and Pages. If we iterate, we should iterate across all of these.

@aduth aduth changed the title CPT: Display notice after trashing a post succeeds or fails CPT: Display notice after post actions succeed or fail Jul 12, 2016
@nylen
Copy link
Contributor

nylen commented Jul 13, 2016

The experience on those listing pages is already quite different:

trash-post-fixed

The immediate "optimistic" update in the CPT listing screen is what makes me think an animation would help.

@aduth
Copy link
Contributor Author

aduth commented Aug 11, 2016

The initial goal of this issue is now satisfied, notably by the following related PRs:

There's some room for improvement here around notice text (including more details about the post) and multiple actions, e.g. #6855 . Additional enhancements should be filed as separate issues.

@aduth aduth closed this as completed Aug 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants