Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking: Enable Gutenberg image editing on simple sites #49096

Closed
8 tasks done
fullofcaffeine opened this issue Jan 21, 2021 · 2 comments
Closed
8 tasks done

Tracking: Enable Gutenberg image editing on simple sites #49096

fullofcaffeine opened this issue Jan 21, 2021 · 2 comments
Labels
[Feature] Post/Page Editor The editor for editing posts and pages. Triaged To be used when issues have been triaged. [Type] Feature Request Feature requests

Comments

@fullofcaffeine
Copy link
Contributor

fullofcaffeine commented Jan 21, 2021 •
edited
Loading

Project: pc9Uba-fo-p2

  • Figure out a way to pass the value for crossOrigin for the img el @fullofcaffeine
  • Conditionally change the passed value of crossorigin depending on whether the site is public or private (D55474-code) @fullofcaffeine
  • Send the proper CORS headers (D46175-code) @fullofcaffeine
  • Set the crossOrigin attribute on the image element created by the image editor (PR) @fullofcaffeine
  • Get a Proof of concept diffs working with the wpcom and gb changesets (main POC diff has been split in the final diffs: D55474-code, D46175-code, D55641-code) @fullofcaffeine
  • Get a PR up with the Gutenberg changes @fullofcaffeine
  • Ship the Gutenberg PR
  • Test across multiple browsers and enable the image editor on wpcom simple sites (D55641-code).
@fullofcaffeine fullofcaffeine added [Type] Feature Request Feature requests and removed [Type] Feature Request Feature requests labels Jan 21, 2021
@nerdysandy nerdysandy added the [Type] Feature Request Feature requests label Jan 22, 2021
@jordesign jordesign added [Feature] Post/Page Editor The editor for editing posts and pages. Triaged To be used when issues have been triaged. labels Feb 2, 2021
@simison
Copy link
Member

simison commented Feb 24, 2021

@fullofcaffeine good to close?

@fullofcaffeine
Copy link
Contributor Author

@fullofcaffeine good to close?

Oh, thanks for the nudge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Post/Page Editor The editor for editing posts and pages. Triaged To be used when issues have been triaged. [Type] Feature Request Feature requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fullofcaffeine @simison @jordesign @nerdysandy